Rework of plugin #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d options by removing separate checked and selected classes. Improved performance by using native operations as much as possible and checking if the input has already been initiated. DRY'd the code.
…lass onto the wrapping container when label or div is hovered. Made the data stored on each input more flexible by storing as an object. Made the delegates more specific.
… class to identify whether the label is for a radio or checkbox
…n on the same input
…roperly handling the change event being fired through a programmatic input.click Added a disabled class for additional styling control of both the label and input. Moved default options outside of function to prevent creating the same defaults over and over.
|
I recommend anyone interested in this plugin to take a look at https://github.com/Akkuma/jquery-ui-checkable as this plugin looks "dead". It should offer you everything this plugin does and then some. |
|
https://github.com/tomekwojcik/jQuery-Custom-Checkboxes also looks good enough. and it doesn't require jquery UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've enhanced the plugin to use event delegation rather than directly binding, streamlined the code a bit more, added in hovering and label support