Skip to content

Commit

Permalink
Revert "Add a "pub workspace" to the root of the engine repository (f…
Browse files Browse the repository at this point in the history
…lutter#53539)"

This reverts commit 8c1dd2f.
  • Loading branch information
itsjustkevin committed Jul 19, 2024
1 parent 8c1dd2f commit babd8a1
Show file tree
Hide file tree
Showing 12 changed files with 59 additions and 248 deletions.
3 changes: 0 additions & 3 deletions ci/licenses_golden/excluded_files
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
../../../flutter/.ci.yaml
../../../flutter/.clang-format
../../../flutter/.clang-tidy
../../../flutter/.dart_tool
../../../flutter/.git
../../../flutter/.gitattributes
../../../flutter/.github
Expand Down Expand Up @@ -253,8 +252,6 @@
../../../flutter/lib/web_ui/pubspec.yaml
../../../flutter/lib/web_ui/test
../../../flutter/prebuilts
../../../flutter/pubspec.lock
../../../flutter/pubspec.yaml
../../../flutter/runtime/dart_isolate_unittests.cc
../../../flutter/runtime/dart_lifecycle_unittests.cc
../../../flutter/runtime/dart_plugin_registrant_unittests.cc
Expand Down
2 changes: 0 additions & 2 deletions lib/ui/channel_buffers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,6 @@ class ChannelBuffers {
@Native<Void Function(Handle, Bool)>(symbol: 'PlatformConfigurationNativeApi::SendChannelUpdate')
external static void _sendChannelUpdate(String name, bool listening);

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
void sendChannelUpdate(String name, {required bool listening}) => _sendChannelUpdate(name, listening);

/// Deprecated. Migrate to [setListener] instead.
Expand Down
2 changes: 0 additions & 2 deletions lib/ui/compositing.dart
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,6 @@ class ShaderMaskEngineLayer extends _EngineLayerWrapper {
/// This does not apply when using the `dart:ui` API directly, without using the
/// Flutter framework bindings, `flutter_test` framework, et al.
abstract class SceneBuilder {
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
factory SceneBuilder() = _NativeSceneBuilder;

/// Pushes a transform operation onto the operation stack.
Expand Down
25 changes: 0 additions & 25 deletions lib/ui/experiments/scene.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,34 +50,24 @@ base class SceneNode extends NativeFieldWrapperClass1 {
return result;
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
static SceneNodeValue fromTransform(Float64List matrix4) {
final SceneNode sceneNode = SceneNode._create();
sceneNode._initFromTransform(matrix4);
return SceneNodeValue.fromValue(sceneNode);
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
void addChild(SceneNode sceneNode) {
_addChild(sceneNode);
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
void setTransform(Float64List matrix4) {
_setTransform(matrix4);
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
void setAnimationState(String animationName, bool playing, bool loop, double weight, double timeScale) {
_setAnimationState(animationName, playing, loop, weight, timeScale);
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
void seekAnimation(String animationName, double time) {
_seekAnimation(animationName, time);
}
Expand Down Expand Up @@ -136,45 +126,32 @@ base class SceneNode extends NativeFieldWrapperClass1 {

/// Returns a fresh instance of [SceneShader].
SceneShader sceneShader() => SceneShader._(this, debugName: _debugName);

}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
class SceneNodeValue {
SceneNodeValue._(this._future, this._value) {
_future?.then((SceneNode result) => _value = result);
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
static SceneNodeValue fromFuture(Future<SceneNode> future) {
return SceneNodeValue._(future, null);
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
static SceneNodeValue fromValue(SceneNode value) {
return SceneNodeValue._(null, value);
}

final Future<SceneNode>? _future;
SceneNode? _value;

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
bool get isComplete {
return _value != null;
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
Future<SceneNode>? get future {
return _future;
}

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
SceneNode? get value {
return _value;
}
Expand Down Expand Up @@ -209,8 +186,6 @@ base class SceneShader extends Shader {
// ignore: unused_field
final String? _debugName;

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
void setCameraTransform(Float64List matrix4) {
_setCameraTransform(matrix4);
}
Expand Down
4 changes: 0 additions & 4 deletions lib/ui/key.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ enum KeyEventType {
/// The key is held, causing a repeated key input.
repeat;

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
String get label {
return switch (this) {
down => 'Key Down',
Expand Down Expand Up @@ -48,8 +46,6 @@ enum KeyEventDeviceType {
/// The device is a device connected to an HDMI bus.
hdmi;

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
String get label {
return switch (this) {
keyboard => 'Keyboard',
Expand Down
2 changes: 0 additions & 2 deletions lib/ui/painting.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2598,8 +2598,6 @@ base class _NativeEngineLayer extends NativeFieldWrapperClass1 implements Engine
/// Paths can be drawn on canvases using [Canvas.drawPath], and can
/// used to create clip regions using [Canvas.clipPath].
abstract class Path {
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
factory Path() = _NativePath;

/// Creates a copy of another [Path].
Expand Down
2 changes: 0 additions & 2 deletions lib/ui/platform_dispatcher.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2195,8 +2195,6 @@ class ViewConstraints {
/// [DisplayFeatureState.postureHalfOpened]. For [DisplayFeatureType.cutout],
/// the state is not used and has the [DisplayFeatureState.unknown] value.
class DisplayFeature {
// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
const DisplayFeature({
required this.bounds,
required this.type,
Expand Down
8 changes: 0 additions & 8 deletions lib/ui/semantics.dart
Original file line number Diff line number Diff line change
Expand Up @@ -281,12 +281,8 @@ class SemanticsAction {
_kFocusIndex: focus,
};

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
static List<SemanticsAction> get values => _kActionById.values.toList(growable: false);

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
static SemanticsAction? fromIndex(int index) => _kActionById[index];

@override
Expand Down Expand Up @@ -639,12 +635,8 @@ class SemanticsFlag {
_kIsExpandedIndex: isExpanded,
};

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
static List<SemanticsFlag> get values => _kFlagById.values.toList(growable: false);

// TODO(matanlurey): have original authors document; see https://github.com/flutter/flutter/issues/151917.
// ignore: public_member_api_docs
static SemanticsFlag? fromIndex(int index) => _kFlagById[index];

@override
Expand Down
173 changes: 0 additions & 173 deletions pubspec.yaml

This file was deleted.

1 change: 0 additions & 1 deletion tools/clang_tidy/test/header_filter_regex_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ void main() {
test('contains every root directory in the regex', () {
// These are a list of directories that should _not_ be included.
const Set<String> intentionallyOmitted = <String>{
'.dart_tool',
'.git',
'.github',
'build_overrides',
Expand Down
Loading

0 comments on commit babd8a1

Please sign in to comment.