[#12169] Update teammates-eslint.yml to mark trailing whitespaces as errors on Ubuntu
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MATES#13154) * Add check for closed issue * Update message * Rephrase message * Add logging * Test * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Add check for closed issue Update message Rephrase message Add logging Test Update pr.yml * [TEAMMATES#13147] Didn't Account for the Timezone in Session Edit Form component tests (TEAMMATES#13148) Update pr.yml Update pr.yml Update pr.yml * Update pr.yml * Update workflow --------- Co-authored-by: Rayson Yeap <88478542+Respirayson@users.noreply.github.com>
|
This issue has been inactive for 3 minutes. It will be closed in 2 minutes if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TEAMMATES#12169
Outline of Solution
I updated
teammates-eslint.ymlto be stricter, indicating trailing whitespaces in.htmlfiles as errors instead of warnings, which were reported to be able to pass using Ubuntu in comparison to Windows linting workflows.I also made the decision to ignore blank lines, as they were required in the templating of the emails sent out to users, and changing them would cause component tests to fail.