Skip to content

Commit

Permalink
Handle calculated MEMORY value along with Aikar's flags (#2568)
Browse files Browse the repository at this point in the history
  • Loading branch information
itzg authored Jan 1, 2024
1 parent cbd1e8d commit 6adda8f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/start-finalExec
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ elif versionLessThan 1.18.1; then
fi
fi

if isTrue ${ENABLE_ROLLING_LOGS:-false}; then
if isTrue "${ENABLE_ROLLING_LOGS:-false}"; then
if ! ${canUseRollingLogs}; then
log "ERROR: Using rolling logs is currently not possible in the selected version due to CVE-2021-44228"
exit 1
Expand Down Expand Up @@ -139,7 +139,7 @@ fi
if isTrue "${USE_AIKAR_FLAGS}"; then
# From https://mcflags.emc.gs/

if (( $(normalizeMemSize "${MAX_MEMORY}") >= $(normalizeMemSize 12g) )); then
if [[ $MAX_MEMORY ]] && (( $(normalizeMemSize "${MAX_MEMORY}") >= $(normalizeMemSize 12g) )); then
log "Using Aikar's >12GB flags"
G1NewSizePercent=40
G1MaxNewSizePercent=50
Expand Down

0 comments on commit 6adda8f

Please sign in to comment.