Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and Improved install scripts. #3006

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

keepittechie
Copy link
Contributor

Updated and Improved install-packages.sh. Added comments, error handling, and enhanced readability of script.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good cleanup overall. Just a few things to put back as I'd like them.

build/alpine/install-packages.sh Outdated Show resolved Hide resolved
build/ol/install-packages.sh Outdated Show resolved Hide resolved
build/ol/install-packages.sh Outdated Show resolved Hide resolved
build/run.sh Outdated Show resolved Hide resolved
build/ubuntu/install-packages.sh Outdated Show resolved Hide resolved
build/ol/install-packages.sh Show resolved Hide resolved
@itzg
Copy link
Owner

itzg commented Jul 21, 2024

Thanks for the follow up. Looks like the commit with the changes hasn't been pushed yet...or maybe Github is being laggy.

...or maybe I'm looking too soon 😀

@keepittechie
Copy link
Contributor Author

@itzg No problem! I just pushed everything.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple tiny tweaks left. Thanks!

build/alpine/install-packages.sh Show resolved Hide resolved
build/ol/install-packages.sh Show resolved Hide resolved
@keepittechie
Copy link
Contributor Author

No problem! It should be corrected now.

@itzg itzg merged commit de1d7f4 into itzg:master Jul 21, 2024
5 checks passed
@keepittechie
Copy link
Contributor Author

Thanks for merging the pull request! Appreciate the feedback and guidance on keeping the scripts readable and consistent. Happy to have contributed and looking forward to working on more improvements in the future if needed. By the way, I have a repository on my profile called "mcsli" where I'm scripting the full installation of Minecraft on Linux. I found your project while searching to make sure I wasn't duplicating something already on GitHub and to learn more about shell scripting. Feel free to check it out if you're interested! Peace!

@itzg
Copy link
Owner

itzg commented Jul 21, 2024

You're welcome and glad to see a fellow Minecraft automation project!

@keepittechie keepittechie deleted the improve-shell-scripts branch July 22, 2024 07:59
@renovate renovate bot mentioned this pull request Sep 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants