Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret backslash escapes for RCON_CMDS #3008

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

quulah
Copy link
Contributor

@quulah quulah commented Jul 21, 2024

Uses echo -e to interpret any included backslash escapes within RCON_CMDS_. Such as the literal \n newlines.

Fixes #3007

@quulah
Copy link
Contributor Author

quulah commented Jul 21, 2024

printf might be more portable. It seems echo has varying implementations across shells and OS's. But this being a container and we have the /bin/bash shebang, I guess we can rely -e on being there.

@itzg
Copy link
Owner

itzg commented Jul 21, 2024

printf might be more portable. It seems echo has varying implementations across shells and OS's. But this being a container and we have the /bin/bash shebang, I guess we can rely -e on being there.

Yeah, I had seen similar comments about portability, but yes, as you said, the container gives us a guaranteed bash implementation.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around! I'll merge this after the PR test finishes.

@itzg itzg merged commit b393b22 into itzg:master Jul 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternate separator for RCON_CMDS_
2 participants