Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SkipReadinessCheck flag #94

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Add SkipReadinessCheck flag #94

merged 1 commit into from
Sep 8, 2024

Conversation

md5nake
Copy link
Contributor

@md5nake md5nake commented Sep 8, 2024

Certain servers have reasons to set the max player count in SLP responses to zero, or omit the players section. The current sanity checking functionality will throw a "server not ready" error when pinging these servers. Additionally, modern servers (e.g those based on Paper) will wait with replying to SLPs until they are fully initialised, which would make the sanity check redundant.

Hence why I propose adding a --skip-readiness-check flag, which bypasses this check and allows servers based on https://github.com/itzg/docker-minecraft-server to pass healthchecks when they're configured to respond to SLPs this way.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I like that it's an opt-in feature since the zero player count check is needed to work around a buggy behavior in older server versions.

@itzg
Copy link
Owner

itzg commented Sep 8, 2024

@itzg itzg merged commit f759dd1 into itzg:master Sep 8, 2024
2 checks passed
@itzg
Copy link
Owner

itzg commented Sep 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants