fix: calendar events without a location crashes plugin #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a calendar event does not have a location specified, the notification key would not properly generate. The changes default the undefined location value to be blank now to represent the value of the location field. Fixes ivan-lednev#438
The default 644 permissions caused them to not trigger. Updated them to 755 permissions so that they are enforced moving forward.
sepatel
changed the title
sepatel
changed the title
sepatel
changed the title
|
Thanks for opening it! Hopefully maintainer approves soon. @ivan-lednev |
|
Thanks for this fix. Waiting patiently for the approval! @ivan-lednev |
|
Hello, @sepatel, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue which to summary caused the plugin to break the moment it activates a calendar event not having a location. The resolution is to do a nullability check and default it to
blankto represent the location for the notification key.Fixes #438