fix: automatic contrasting colors for texts when using color override #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of merging this? It would be great. Tell me if I can help anyway else. |
ivan-lednev
requested changes
Sep 18, 2024
Comment on lines
+53
to
+65
| $: override = useColorOverride(task); | ||
| // todo: hide in hook | ||
| $: backgroundColor = | ||
| $override || "var(--time-block-bg-color, var(--background-primary))"; | ||
|
|
||
| $: ({ | ||
| faint, | ||
| muted, | ||
| normal, | ||
| } = $override | ||
| ? getTextColorWithEnoughContrast(backgroundColor) | ||
| : { faint: "", muted: "", normal: "" } | ||
| ); |
There was a problem hiding this comment.
This solution is simple, and it works, but let's keep all the color related code in one place. This should go into src/ui/hooks/use-color.ts. There, the same calculation is made for a different feature: colored timelines. We should check if a task matches an override there, and return the override colors. Overrides should take precedence over colored timeline values.
ivan-lednev
force-pushed
the
main
branch
2 times, most recently
from
648a446
to
ca91e6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automatic contrasting colors to texts on overrided background colors.
After @ivan-lednev asked to use
getTextColorWithEnoughContrastover @bogdansalyp 's proposal #480 , I tried to implement it. First time with Svelte, but I think I did it right.May resolve #481