-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to embassy-net 0.5 #50
base: master
Are you sure you want to change the base?
Conversation
What do you need on the esp-wifi side? embassy-net-driver didn't change so you should be able to use embassy-net@0.5 with the currently released esp-wifi... in theory :D, let me know if that's not the case. |
Ah right - you are only depending on the |
Current esp-wifi uses smoltcp-0.11, from the user-side you want to have everything on the same smoltcp version. |
True, but it doesn't stop you using embassy-net because it uses its own device trait. I opened an upstream issue smoltcp to do the same btw: smoltcp-rs/smoltcp#1010 |
Yes, it is just mildly annoying since you have to put in the configuration for smoltcp twice like I did in wot-rust/wot-esp-hal-demo#14 |
38d82bd
to
289421a
Compare
* Adapt changes to upstream embassy-net * Remove leftover imports And use the now release embassy-net. * Implement Readable for embassy-net 0.5 * Simplify the internal helpers --------- Co-authored-by: Shaw Drastin <168159404+showier-drastic@users.noreply.github.com>
289421a
to
5a85bcc
Compare
Had been a while, do you have time to land it and cut a release? Doesn't look like we'll have an esp-wifi update much soon ^^; |
Is it working fine for you in the meantime? |
I had a branch for the mdns support and it works well. There is the pitfall of having to configure two smoltcp but everything works. |
Alright. Another user in the Embassy matrix chat was trying it out with a pi pico w I think and was having troubles getting the incoming multicast traffic (outgoing was working fine) but I doubt this can be a problem of edge-net if you say it works for you with baremetal esp. I'll merge in a few days and release. |
I can try to test it more in the next days if you prefer, today I'm far a bit far from the board. |
Looking forward to see this being merged, so that I can upgrade to I've been testing a bit in the following, using a patched version for this PR: |
If that lands we do not have anymore the pitfall of having two smoltcp in the deptree :) |
(Not immediately as we might have to wait until
esp-wifi
gets it as well.)