Add tests #2
Open
Add tests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a validation of the schema and a validation of what was in the samples. We had to update/clean up the samples a bit: * The StandardsRegExt record really has no relationship to VODataService, so that's dropped. * We are defusing the extendedtable test because that needs extra validation arguments, which we don't want to fiddle in (and we don't want that kind of thing anyway) * We add schemaLocation attributes to the SimpleDalRegExt records. * We drop the ancient ProtoSpectralAccess thing from the SSA record.
Actually, we updated the VizieR trapezium record from upstream (but hacked it a bit for our purposes here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills out the test target recommended for ivoatex makefiles. At this point, we check that there's no version tag on the schema for REC-s, the validity of the schema file, and the validity of a bunch of example files that between them probably cover the big bulk of schema-controlled VODataService features. The biggest hole probably is that none of the more basic resource types is exercised.