Fix bug: clamp the controller output before making it interface vector

ixaxaar · Dec 20, 2017 · 08bd220 · 08bd220
1 parent 1abd4c4
commit 08bd220
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/dnc/dnc.py b/dnc/dnc.py
@@ -178,14 +178,15 @@ def _layer_forward(self, input, layer, hx=(None, None), pass_through_memory=True
     input, chx = self.rnns[layer](input.unsqueeze(1), chx)
     input = input.squeeze(1)
 
-    # the interface vector
-    ξ = input
     # clip the controller output
     if self.clip != 0:
       output = T.clamp(input, -self.clip, self.clip)
     else:
       output = input
 
+    # the interface vector
+    ξ = output
+
     # pass through memory
     if pass_through_memory:
       if self.share_memory: