This repository has been archived by the owner on Jun 5, 2021. It is now read-only.
Support null safety and upgrading pre 1.12 Android projects #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvchenyang
commented
Apr 7, 2021
lvchenyang
commented
- support null safety
- upgrading pre 1.12 Android projects
j0j00
reviewed
May 30, 2021
| @@ -15,8 +15,10 @@ class FlutterUserAgent { | |||
| /// the native platform. | |||
| static Future init({force: false}) async { | |||
| if (_properties == null || force) { | |||
| Map<dynamic, dynamic> properties= (await _channel.invokeMethod('getProperties')); | |||
| print(Map.unmodifiable(properties)); | |||
There was a problem hiding this comment.
The print statement should not be there.
j0j00
reviewed
May 30, 2021
| @@ -0,0 +1 @@ | |||
| {"info":"This is a generated file; do not edit or check into version control.","plugins":{"ios":[{"name":"flutter_user_agent","path":"/Users/lvchenyang/AndroidStudioProjects/flutter_user_agent/","dependencies":[]}],"android":[{"name":"flutter_user_agent","path":"/Users/lvchenyang/AndroidStudioProjects/flutter_user_agent/","dependencies":[]}],"macos":[],"linux":[],"windows":[],"web":[]},"dependencyGraph":[{"name":"flutter_user_agent","dependencies":[]}],"date_created":"2021-04-07 14:39:14.468191","version":"2.0.3"} | |||
There was a problem hiding this comment.
I don't think this file should be in version control
j0j00
reviewed
May 30, 2021
| @@ -0,0 +1,14 @@ | |||
| #!/bin/sh | |||
|
Is the flutterembedding stuff required for null safety or just an extra? |
|
#17 seems to try and achieve that, but with more specific changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.