Merge pull request #3 from j0k3r/head-request

Avoid HEAD request to return false

src/SafeCurl.php

@@ -176,6 +176,11 @@ public function execute($url)
         $headerSize = curl_getinfo($this->curlHandle, CURLINFO_HEADER_SIZE);
         $response = substr($response, $headerSize);
 
+        // substr return false when string goes empty (in case of a HEAD request or when reponse body is empty for example)
+        if (false === $response) {
+            return '';
+        }
+
         return $response;
     }
 }

tests/SafeCurlTest.php

@@ -5,7 +5,7 @@
 
 class SafeCurlTest extends \PHPUnit_Framework_TestCase
 {
-    public function testFunctionnal()
+    public function testFunctionnalGET()
     {
         $handle = curl_init();
 
@@ -17,6 +17,21 @@ public function testFunctionnal()
         $this->assertNotContains('HTTP/1.1 302 Found', $response);
     }
 
+    public function testFunctionnalHEAD()
+    {
+        $handle = curl_init();
+        // for an unknown reason, HEAD request failed: https://travis-ci.org/j0k3r/safecurl/jobs/91936743
+        // curl_setopt($handle, CURLOPT_CUSTOMREQUEST, 'HEAD');
+        curl_setopt($handle, CURLOPT_NOBODY, true);
+
+        $safeCurl = new SafeCurl($handle);
+        $response = $safeCurl->execute('http://40.media.tumblr.com/39e917383bf5fe228b82fef850251220/tumblr_nxyw8cjiYx1u7jfjwo1_100.jpg');
+
+        $this->assertEquals('', $response);
+        $this->assertEquals($handle, $safeCurl->getCurlHandle());
+        $this->assertNotContains('HTTP/1.1 302 Found', $response);
+    }
+
     /**
      * @expectedException fin1te\SafeCurl\Exception
      * @expectedExceptionMessage SafeCurl expects a valid cURL resource - "NULL" provided.