Feature: Add alternative light designs and introduce unit and integration tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jackw
commented
Feb 20, 2024
•
jackw
commented
- Add a new option to select different traffic light styles (default, rounded, side-lights)
- Add some basic tests for utils
- Add plugin-e2e package with playwright for e2e tests
- Fixes bugs with calculateRowsAndColumns where itemcount and containerWidth weren't being considered causing potential layout breakages
- Fixes the following layout bug with calculateRowsAndColumns using data.series.length causing broken layouts due to returning a different length to useData's values (which we should consider the source of truth).
| Before | After |
|---|---|
 |
 |
jackw
changed the title
sunker
reviewed
Feb 20, 2024
| await panelEditPage.getQueryEditorRow('A').getByText('Scenario').click(); | ||
| await page.keyboard.insertText('CSV Content'); | ||
| await page.keyboard.press('Enter'); | ||
| await page.waitForFunction(() => (window as any).monaco); |
There was a problem hiding this comment.
don't think you need this cast - plugin-e2e already defines monaco as global.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.