Improving fuse response log for better debuggability

jacobsa · Jun 25, 2024 · a484376 · a484376
1 parent 7285af0
commit a484376
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/connection.go b/connection.go
@@ -510,7 +510,7 @@ func (c *Connection) Reply(ctx context.Context, opErr error) error {
 	// Debug logging
 	if c.debugLogger != nil {
 		if opErr == nil {
-			c.debugLog(fuseID, 1, "-> OK (%s)", describeResponse(op))
+			c.debugLog(fuseID, 1, "-> %s", describeResponse(op))
 		} else {
 			c.debugLog(fuseID, 1, "-> Error: %q", opErr.Error())
 		}

diff --git a/debug.go b/debug.go
@@ -144,11 +144,10 @@ func describeResponse(op interface{}) string {
 			addComponent("inode %v", entry.Child)
 		}
 	}
-
 	switch typed := op.(type) {
 	case *fuseops.OpenFileOp:
 		addComponent("handle %d", typed.Handle)
 	}
 
-	return fmt.Sprintf("%s", strings.Join(components, ", "))
+	return fmt.Sprintf("%s (%s)", opName(op), strings.Join(components, ", "))
 }