Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds file handle in OpenFile and ReleaseFileHandle logs #164

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

pat-vish
Copy link
Contributor

@pat-vish pat-vish commented Jun 6, 2024

Description

As of now OpenFile and ReleaseFileHandle logs do not have file handles. In order to analyse logs, one needs to know which handle is assigned to a file when it is opened and when closing which handle is being released.

Link to the issue in case of a bug fix

NA

Testing Details

  1. Manual - Manually verified with GCSFuse that logs are printing file handles as expected:
{"timestamp":{"seconds":1717657690,"nanos":285345660},"severity":"TRACE","message":"fuse_debug: Op 0x0000001a        connection.go:420] <- OpenFile (inode 2, PID 1159034)"}
{"timestamp":{"seconds":1717657690,"nanos":285426200},"severity":"TRACE","message":"fuse_debug: Op 0x0000001a        connection.go:513] -> OK (Handle 1)"}
{"timestamp":{"seconds":1717657690,"nanos":285835240},"severity":"TRACE","message":"fuse_debug: Op 0x0000001e        connection.go:420] <- ReleaseFileHandle (PID 0, Handle 1)"}
  1. Unit tests - NA
  2. Integration tests - NA

debug.go Outdated Show resolved Hide resolved
debug.go Outdated Show resolved Hide resolved
@pat-vish pat-vish requested a review from stapelberg June 7, 2024 09:21
@stapelberg stapelberg merged commit 7285af0 into jacobsa:master Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants