Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define one e2e workflow #2395

Merged
merged 1 commit into from
Dec 12, 2023
Merged

define one e2e workflow #2395

merged 1 commit into from
Dec 12, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 12, 2023

Which problem is this PR solving?

  • Help maintain e2e github-actions dependencies update as the workflow is in .github/workflows directory

Description of the changes

  • mutualise all e2e workflows in one matrix workflow

How was this change tested?

  • CI

Checklist

Copy link

openshift-ci bot commented Dec 12, 2023

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a jaegertracing member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba8a0d5) 87.71% compared to head (f346688) 87.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2395   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files         102      102           
  Lines        7268     7268           
=======================================
  Hits         6375     6375           
  Misses        697      697           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 marked this pull request as draft December 12, 2023 06:44
@mmorel-35 mmorel-35 changed the title define reusable e2e workflow define one e2e workflow Dec 12, 2023
@mmorel-35 mmorel-35 marked this pull request as ready for review December 12, 2023 07:05
Copy link
Collaborator

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this PR :D!

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@iblancasa iblancasa merged commit d4ab65e into jaegertracing:main Dec 12, 2023
40 checks passed
@mmorel-35 mmorel-35 deleted the e2e branch December 14, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants