Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2225 #2622

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fixes #2225 #2622

wants to merge 4 commits into from

Conversation

antoniomerlin
Copy link
Contributor

By providing default ingressClass using detectDefaultIngressClass func updated API call to use client.Reader instead of client.Client

Which problem is this PR solving?

Description of the changes

  • detectDefaultIngressClass func updated API call to use client.Reader instead of client.Client

How was this change tested?

  • By running TestDetectDefaultIngressClass in autodetect/main_test.go

Checklist

…ctDefaultIngressClass func updated API call to use client.Reader instead of client.Client

Signed-off-by: amerlin <antoniomerlindev@gmail.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.71%. Comparing base (70e511a) to head (f82e648).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2622   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files         102      102           
  Lines        7308     7308           
=======================================
  Hits         6410     6410           
  Misses        701      701           
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iblancasa
Copy link
Collaborator

Thanks for your contribution! Can you create a test?

@antoniomerlin
Copy link
Contributor Author

Hi, @iblancasa test is already preset in pkg/autodetect/main_test.go and its working. Do i need to add anything else ?

@iblancasa
Copy link
Collaborator

I was thinking more about an E2E test or adding a new test. If after the change, none of the tests are modified it means we are not checking for the correct result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Ingress jaeger-query should use the default IngressClass if one is not provided
2 participants