Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go to 1.22 and controller-gen to 1.14 #2646

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

pavolloffay
Copy link
Member

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Copy link
Collaborator

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing... I think very likely some dependencies would need to be upgraded

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Copy link
Member Author

Yes the controller-gen needs to be updated. done

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay changed the title Bump go to 1.22 Bump go to 1.22 and controller-gen to 1.14 Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (a649f46) to head (5b2746d).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2646       +/-   ##
===========================================
- Coverage   87.72%   75.35%   -12.37%     
===========================================
  Files         102      124       +22     
  Lines        7314     8525     +1211     
===========================================
+ Hits         6416     6424        +8     
- Misses        701     1904     +1203     
  Partials      197      197               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavolloffay pavolloffay merged commit 3636f15 into jaegertracing:main Aug 9, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants