WorldInspector Entity Filter #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
requested changes
Apr 19, 2024
Comment on lines
296
to
310
| if self.word.is_empty() { | ||
| entities | ||
| } else { | ||
| entities | ||
| .into_iter() | ||
| .filter(|entity| { | ||
| self_or_children_satisfy_filter( | ||
| world, | ||
| *entity, | ||
| self.word.as_str(), | ||
| self.is_fuzzy, | ||
| ) | ||
| }) | ||
| .collect::<Vec<_>>() | ||
| } |
There was a problem hiding this comment.
can you pass &mut Vec<Entity> here and use retain instead of allocating a new vec?
Comment on lines
371
to
376
| (if !is_fuzzy { | ||
| name.to_lowercase().contains(&filter) | ||
| } else { | ||
| let matcher = SkimMatcherV2::default(); | ||
| matcher.fuzzy_match(name.as_str(), filter).is_some() | ||
| }) || { |
There was a problem hiding this comment.
can you write the result of the if into a variable like self_matches or something? I think that would be more readable
| @@ -47,6 +47,8 @@ smallvec = "1.10" | |||
|
|
|||
| egui-dropdown = "0.7.0" | |||
|
|
|||
| fuzzy-matcher = "0.3.7" | |||
There was a problem hiding this comment.
looks like fuzzy-matcher doesn't introduce any new dependencies transitively so I'm fine adding this
|
or maybe fuzzy search should just be the default? I'm not sure. It would look cleaner to remove the option at least. |
|
I've pushed the fixes since I'm preparing a release right now anyways. I've decided to keep the fuzzy option for now and ask after a while what people would prefer after having used it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of solves #133
I just hacked this together and didn't polish it too much since I'm not sure what your expectations are. I also added a togglable option to enable fuzzy matching since it felt right for the moment, but I'm also open to remove it again if you don't like it.