Support for :unless, passing attributes, parametrizing :event_class_name, and cleanup #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We recently introduced
timeline_fu
into a project, and made some changes which we think would be helpful for everyone.This fork was based off
szajbus/timeline_fu
and incorporates their features, which came in handy.It also adds support for specifying
:event_class_name
, soTimelineEvent
is not hardcoded, as well as specifying more than one event class. This is helpful in situations where tracking for events byComment
should be handled byCommentEvent
and be separate fromPost
, which is handled byPostEvent
, for example. We also found it helpful to specify:event_class_name => ["CommentEvent", "UserEvent"]
, thus being able to easily build an audit log for a particular Comment, as well as an entire activity log for a User.Finally, we cleaned up the gemspec and added the gem’s dependencies to it, introduced bundler, and appraisal, so the gem is now tested against the latest stable version of
ActiveRecord
2.3.x
,3.0.x
, and3.1.x
(all tests currently pass, of course)We hope you approve and thanks for starting
timeline_fu
!Cheers,
The folks at One Design Company