Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and improvements #6

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Various fixes and improvements #6

wants to merge 10 commits into from

Conversation

cs
Copy link
Contributor

@cs cs commented Aug 29, 2011

  1. pulled from damireh: added indices to timeline_events migration
  2. pulled from rohit: Remove extra whitespace from migration template
  3. .gititnore all *.rbc files (generated by rubinius)
  4. require active_record instead of activerecord in order to support 3.1 series or rails (maybe 3.0 series as well)
  5. fix test. for some reason moch has_entry method is undefined on my system. replace has_entry with "full" expectations to fix the issue (same technique as in other tests). note: has_entry is supposed to be defined in mocha.
  6. multitenancy support: add belongs_to :account to timeline event incl. support for passing :account to the fires macro. tests are up to date as well.

hope you like it! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants