Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create logger for the module scope instead of using global logger #246

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

danbeibei
Copy link

Follow the recommended way of using the logger in the generated Python modules (https://docs.python.org/3/library/logging.html) by creating a logger in each module: logger = logging.getLogger(__name__). Otherwise, at runtime, it will interact with other modules' loggers.

@jameskermode
Copy link
Owner

Here's the important line in the failing CI logs: https://github.com/jameskermode/f90wrap/actions/runs/12667563380/job/35301175384?pr=246#step:4:1691

Looks like a change in where ComplexWarning exception is located numpy, fix should be similar to https://github.com/dmlc/dgl/pull/7768/files

@jameskermode jameskermode merged commit 10bc76e into jameskermode:master Jan 9, 2025
23 checks passed
@jameskermode
Copy link
Owner

thank you!

@danbeibei danbeibei deleted the fix_logger_scope branch January 9, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants