Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo/grammar #380

Merged
merged 1 commit into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DocsV2/docs/Queuing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ provider

## Adjusting Consummation Delay

Normally, the queue will consume all of it's queued tasks every 30 seconds.
Normally, the queue will consume all of its queued tasks every 30 seconds.
You can adjust this delay in the `appsettings.json` file.

```json
Expand Down
2 changes: 1 addition & 1 deletion DocsV2/docs/Scheduler/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ scheduler

For this example, `SendNightlyReportsEmailJob` and `SendPendingNotifications` will share a dedicated pipeline/thread.

`RebuildStaticCachedData` has it's own dedicated worker so it will not affect the other tasks if it does take a long time to run.
`RebuildStaticCachedData` has its own dedicated worker so it will not affect the other tasks if it does take a long time to run.

### Useful For

Expand Down
4 changes: 2 additions & 2 deletions Src/Coravel/Cache/InMemoryCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class InMemoryCache : ICache
private readonly IMemoryCache _cache;
private readonly HashSet<string> _keys;
// I could create a new type for a thread safe hashset.
// But, the Flush() method needs to be safe in it's entire operation.
// But, the Flush() method needs to be safe in its entire operation.
private readonly object _setLock;

public InMemoryCache(IMemoryCache cache)
Expand Down Expand Up @@ -133,4 +133,4 @@ private void EvictionCallback(object key, object value, EvictionReason reason, o
}
}
}
}
}
4 changes: 2 additions & 2 deletions Src/Coravel/Events/Dispatcher.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public IEventSubscription<TEvent> Register<TEvent>() where TEvent : IEvent
}

/// <summary>
/// Broadcasts an event to be handled by it's subscribed listeners.
/// Broadcasts an event to be handled by its subscribed listeners.
/// </summary>
/// <param name="toBroadcast"></param>
/// <typeparam name="TEvent"></typeparam>
Expand Down Expand Up @@ -107,4 +107,4 @@ public IEventSubscription<TEvent> Subscribe<TListener>() where TListener : IList
return this;
}
}
}
}
4 changes: 2 additions & 2 deletions Src/Coravel/Queuing/Queue.cs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ private ActionOrAsyncFunc EnqueueInvocable<T>(Action<IInvocable> beforeInvoked =
{
Type invocableType = typeof(T);
// This allows us to scope the scheduled IInvocable object
// and allow DI to inject it's dependencies.
// and allow DI to inject its dependencies.
await using (var scope = this._scopeFactory.CreateAsyncScope())
{
if (scope.ServiceProvider.GetService(invocableType) is IInvocable invocable)
Expand Down Expand Up @@ -227,4 +227,4 @@ private async Task InvokeTask(ActionOrAsyncFunc task)
}
}
}
}
}
4 changes: 2 additions & 2 deletions Src/Coravel/Scheduling/Schedule/Interfaces/IScheduler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ public interface IScheduler

/// <summary>
/// Begin scheduling further tasks on an isolated worker.
/// A worker will run all scheduled tasks on it's own separate thread.
/// A worker will run all scheduled tasks on its own separate thread.
/// </summary>
/// <param name="workerName"></param>
/// <returns></returns>
IScheduler OnWorker(string workerName);
}
}
}
8 changes: 4 additions & 4 deletions Src/Coravel/Scheduling/Schedule/Scheduler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ async Task Invoke()
}

/// <summary>
/// This will grab all the scheduled tasks and combine each task into it's assigned "worker".
/// Each worker runs on it's own thread and will process it's assigned scheduled tasks asynchronously.
/// This will grab all the scheduled tasks and combine each task into its assigned "worker".
/// Each worker runs on its own thread and will process its assigned scheduled tasks asynchronously.
/// This method return a list of active tasks (one per worker - which needs to be awaited).
/// </summary>
/// <param name="utcDate"></param>
Expand Down Expand Up @@ -223,7 +223,7 @@ private async Task RunWorkersAt(DateTime utcDate, bool isFirstTick)
}
}

// We want each "worker" (indicated by the "WorkerName" prop) to run on it's own thread.
// We want each "worker" (indicated by the "WorkerName" prop) to run on its own thread.
// So we'll group all the "due" scheduled events (the actual work the user wants to perform) into
// buckets for each "worker".
var groupedScheduledEvents = scheduledWorkers
Expand Down Expand Up @@ -267,4 +267,4 @@ public ScheduledTask(string workerName, ScheduledEvent scheduledEvent)
public string WorkerName { get; set; }
}
}
}
}
Loading