-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cif
method that takes a file handle
#10
Comments
I still get caught trying to give a plain path to the Anyway, I like the suggestion to have an IO stream as an argument. Originally it was difficult to do this because the C |
Yup, that's exactly what I was thinking. I'm not sure when I can get to this, but if I do I'll send in a PR. |
Version 0.7.0 (just released) reverts to interpreting a string passed to the |
The latest commit (3fcfa27) now includes a CIF constructor with an |
It appears that the only methods for reading in CIF file are
julia> methods(Cif) # 4 methods for type constructor: [1] Cif() @ ~/.julia/packages/CrystalInfoFramework/lBBNH/src/cif_base.jl:313 [2] Cif(s::AbstractString; verbose, version, source) @ ~/.julia/packages/CrystalInfoFramework/lBBNH/src/cif_base.jl:686 [3] Cif(s::FilePathsBase.AbstractPath; verbose, native, version) @ ~/.julia/packages/CrystalInfoFramework/lBBNH/src/cif_base.jl:660 [4] Cif(contents::Dict{String, T}, original_file::FilePathsBase.AbstractPath, header_comments::String) where {V, T<:CifContainer{V}} @ ~/.julia/packages/CrystalInfoFramework/lBBNH/src/cif_base.jl:304
Although it's not what I expected on my first attempt to use the package, I understand why a string argument is parsed as CIF contents instead of a file path - Julia really does need a dedicated path type. However, I would expect giving
Cif()
a file handle to work properly, so something along the lines ofcould work.
The text was updated successfully, but these errors were encountered: