v1.5.70 - AsyncApexJob Guard Clause

README.md

@@ -24,12 +24,12 @@ As well, don't miss [the Wiki](../../wiki), which includes even more info for co
 
 ## Deployment & Setup
 
-<a href="https://login.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008SnlnAAC">
+<a href="https://login.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008SnrXAAS">
   <img alt="Deploy to Salesforce"
        src="./media/deploy-package-to-prod.png">
 </a>
 
-<a href="https://test.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008SnlnAAC">
+<a href="https://test.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008SnrXAAS">
   <img alt="Deploy to Salesforce Sandbox"
        src="./media/deploy-package-to-sandbox.png">
 </a>

extra-tests/classes/RollupLimitsTest.cls

@@ -0,0 +1,7 @@
+@IsTest
+private class RollupLimitsTest {
+  @IsTest
+  static void correctlyReferencesOrgLimits() {
+    System.assertEquals(false, new RollupLimits.Tester(RollupControl__mdt.getInstance('Org_Default'), false).hasExceededOrgAsyncLimit());
+  }
+}

extra-tests/classes/RollupLimitsTest.cls-meta.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ApexClass xmlns="http://soap.sforce.com/2006/04/metadata">
+    <apiVersion>57.0</apiVersion>
+    <status>Active</status>
+</ApexClass>

extra-tests/classes/RollupTests.cls

@@ -2847,4 +2847,20 @@ private class RollupTests {
       mock.Records[0].get('Description')
     );
   }
+
+  @IsTest
+  static void fallsBackToRunningSyncWhenOutOfAsyncJobs() {
+    RollupTestUtils.DMLMock mock = RollupTestUtils.loadAccountIdMock(
+      new List<ContactPointAddress>{ new ContactPointAddress(Name = 'One', PreferenceRank = 50) }
+    );
+    Rollup.apexContext = TriggerOperation.AFTER_INSERT;
+    // one over the default limit
+    RollupLimits.orgAsyncJobsUsed = 250001;
+
+    // specifically no Test.startTest()/Test.stopTest() to prove it's been run sync
+    Rollup.sumFromApex(ContactPointAddress.PreferenceRank, ContactPointAddress.ParentId, Account.Id, Account.AnnualRevenue, Account.SObjectType).runCalc();
+
+    System.assertEquals(1, mock.Records.size());
+    System.assertEquals(50, mock.Records[0].get(Account.AnnualRevenue));
+  }
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "apex-rollup",
-  "version": "1.5.69",
+  "version": "1.5.70",
   "description": "Fast, configurable, elastically scaling custom rollup solution. Apex Invocable action, one-liner Apex trigger/CMDT-driven logic, and scheduled Apex-ready.",
   "repository": {
     "type": "git",

rollup-namespaced/README.md

@@ -18,12 +18,12 @@ For more info, see the base `README`.
 
 ## Deployment & Setup
 
-<a href="https://login.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008SnlsAAC">
+<a href="https://login.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008SnrcAAC">
   <img alt="Deploy to Salesforce"
        src="./media/deploy-package-to-prod.png">
 </a>
 
-<a href="https://test.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008SnlsAAC">
+<a href="https://test.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008SnrcAAC">
   <img alt="Deploy to Salesforce Sandbox"
        src="./media/deploy-package-to-sandbox.png">
 </a>

rollup-namespaced/sfdx-project.json

@@ -4,8 +4,8 @@
             "default": true,
             "package": "apex-rollup-namespaced",
             "path": "rollup-namespaced/source/rollup",
-            "versionName": "Tech debt cleanup",
-            "versionNumber": "1.0.42.0",
+            "versionName": "Check org limits for AsyncApexJob execution prior to enqueueing/batching",
+            "versionNumber": "1.0.43.0",
             "versionDescription": "Fast, configurable, elastically scaling custom rollup solution. Apex Invocable action, one-liner Apex trigger/CMDT-driven logic, and scheduled Apex-ready.",
             "releaseNotesUrl": "https://github.com/jamessimone/apex-rollup/releases/latest",
             "unpackagedMetadata": {
@@ -36,6 +36,7 @@
         "apex-rollup-namespaced@1.0.39-0": "04t6g000008SneMAAS",
         "apex-rollup-namespaced@1.0.40-0": "04t6g000008SnebAAC",
         "apex-rollup-namespaced@1.0.41-0": "04t6g000008SnldAAC",
-        "apex-rollup-namespaced@1.0.42-0": "04t6g000008SnlsAAC"
+        "apex-rollup-namespaced@1.0.42-0": "04t6g000008SnlsAAC",
+        "apex-rollup-namespaced@1.0.43-0": "04t6g000008SnrcAAC"
     }
 }

rollup/core/classes/RollupAsyncProcessor.cls

@@ -1058,8 +1058,9 @@ global virtual without sharing class RollupAsyncProcessor extends Rollup impleme
   }
 
   private Boolean ingestRollupControlData(List<RollupAsyncProcessor> syncRollups) {
-    Boolean isRunningAsnyc = this.getIsRunningAsync();
+    Boolean isRunningAsync = this.getIsRunningAsync();
     Boolean shouldRollupsRunWithoutCustomSetting = false;
+    RollupLimits.Tester limitTester = new RollupLimits.Tester(this.rollupControl, isRunningAsync);
     for (Integer index = this.rollups.size() - 1; index >= 0; index--) {
       RollupAsyncProcessor rollup = this.rollups[index];
       shouldRollupsRunWithoutCustomSetting = rollup.getCanRollupWithoutCustomSetting();
@@ -1068,8 +1069,14 @@ global virtual without sharing class RollupAsyncProcessor extends Rollup impleme
       Boolean shouldRunSyncDeferred = this.getShouldRunSyncDeferred(rollup);
       Boolean couldRunSync =
         rollup.rollupControl.ShouldRunAs__c == RollupMetaPicklists.ShouldRunAs.Synchronous ||
-        (isRunningAsnyc && this.getIsTimingOut(rollup.rollupControl, rollup) == false) ||
+        (isRunningAsync && this.getIsTimingOut(rollup.rollupControl, rollup) == false) ||
         this.isSingleRecordSyncUpdate(rollup);
+
+      if (limitTester.hasExceededOrgAsyncLimit()) {
+        couldRunSync = true;
+        shouldRunSyncDeferred = false;
+      }
+
       String hashedRollupKey = rollup.getHashedContents() + rollup.calcItems?.hashCode() + rollup.oldCalcItems?.hashCode();
       if (hashedRollups.contains(hashedRollupKey)) {
         this.rollups.remove(index);

rollup/core/classes/RollupLimits.cls

@@ -1,13 +1,34 @@
 public without sharing class RollupLimits {
   @TestVisible
   private static Integer stubbedQueryRows;
+  @TestVisible
+  private static Integer orgAsyncJobsUsed;
 
   private static final Integer SYNC_TIMEOUT_INTERVAL_MS = 3000;
   private static final Integer ASYNC_TIMEOUT_INTERVAL_MS = 13000;
 
   private static final Integer LIMIT_HEAP_SIZE = Limits.getLimitHeapSize();
   private static final Integer LIMIT_QUERY_ROWS = 50000;
 
+  private static final Boolean HAS_EXCEEDED_ORG_ASYNC_JOB_LIMIT {
+    get {
+      Integer countOfJobsUsed = 0;
+      Integer asyncJobLimit = 250000;
+      // at the moment, packaging orgs run tests synchronously, which produces an error when fetching System.OrgLimits.getMap()
+      // this is a workaround until it's safe to access OrgLimits from a synchronously running test
+      if (HAS_EXCEEDED_ORG_ASYNC_JOB_LIMIT == null && Test.isRunningTest() == false) {
+        System.OrgLimit asyncLimit = System.OrgLimits.getMap().get('DailyAsyncApexExecutions');
+        asyncJobLimit = asyncLimit.getLimit();
+        countOfJobsUsed = asyncLimit.getValue();
+      } else if (HAS_EXCEEDED_ORG_ASYNC_JOB_LIMIT == null && orgAsyncJobsUsed != null) {
+        countOfJobsUsed = orgAsyncJobsUsed;
+      }
+      HAS_EXCEEDED_ORG_ASYNC_JOB_LIMIT = countOfJobsUsed - asyncJobLimit > 0;
+      return HAS_EXCEEDED_ORG_ASYNC_JOB_LIMIT;
+    }
+    set;
+  }
+
   public class Tester {
     private final transient RollupControl__mdt control;
     private final transient Boolean isRunningAsync;
@@ -61,5 +82,9 @@ public without sharing class RollupLimits {
       Integer remainingQueryRows = this.control.MaxQueryRows__c?.intValue() - queryRowsUsed;
       return remainingQueryRows > 0 ? remainingQueryRows : 0;
     }
+
+    public Boolean hasExceededOrgAsyncLimit() {
+      return HAS_EXCEEDED_ORG_ASYNC_JOB_LIMIT;
+    }
   }
 }

rollup/core/classes/RollupLogger.cls

@@ -1,7 +1,7 @@
 global without sharing virtual class RollupLogger implements ILogger {
   @TestVisible
   // this gets updated via the pipeline as the version number gets incremented
-  private static final String CURRENT_VERSION_NUMBER = 'v1.5.69';
+  private static final String CURRENT_VERSION_NUMBER = 'v1.5.70';
   private static final LoggingLevel FALLBACK_LOGGING_LEVEL = LoggingLevel.DEBUG;
   private static final RollupPlugin PLUGIN = new RollupPlugin();
 

sfdx-project.json

@@ -4,8 +4,8 @@
             "default": true,
             "package": "apex-rollup",
             "path": "rollup",
-            "versionName": "Tech debt cleanup",
-            "versionNumber": "1.5.69.0",
+            "versionName": "Check org limits for AsyncApexJob execution prior to enqueueing/batching",
+            "versionNumber": "1.5.70.0",
             "versionDescription": "Fast, configurable, elastically scaling custom rollup solution. Apex Invocable action, one-liner Apex trigger/CMDT-driven logic, and scheduled Apex-ready.",
             "releaseNotesUrl": "https://github.com/jamessimone/apex-rollup/releases/latest",
             "unpackagedMetadata": {
@@ -106,6 +106,7 @@
         "apex-rollup@1.5.66-0": "04t6g000008SneHAAS",
         "apex-rollup@1.5.67-0": "04t6g000008SneWAAS",
         "apex-rollup@1.5.68-0": "04t6g000008SnlYAAS",
-        "apex-rollup@1.5.69-0": "04t6g000008SnlnAAC"
+        "apex-rollup@1.5.69-0": "04t6g000008SnlnAAC",
+        "apex-rollup@1.5.70-0": "04t6g000008SnrXAAS"
     }
 }