Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.15 - Continued Bulk Full Recalc Work #566

Merged
merged 7 commits into from
Feb 23, 2024
Merged

v1.6.15 - Continued Bulk Full Recalc Work #566

merged 7 commits into from
Feb 23, 2024

Conversation

jamessimone
Copy link
Owner

  • Standardizes prefixing System namespace for logging levels, which was inconsistent
  • updates polling time in Full Recalc app from 3 seconds to 10 seconds between polls to minimize number of logs produced while waiting for full recalcs to finish
  • fixes an inconsistency across batch full recalc runs where state tracking could fail if parents present in disparate batch chunks - say, chunks 1, 3, 5, etc... - had children qualify in only some of those batches. This has been a complicated and pernicious issue, and in many ways is a return to some prior version of the parent tracking present in prior versions of Apex Rollup. I've added some logging to the end of each batch chunk to monitor how this affects LDV orgs

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 93.50649% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 96.54%. Comparing base (7270aa9) to head (3a9cdf9).

❗ Current head 3a9cdf9 differs from pull request most recent head ae58381. Consider uploading reports for the commit ae58381 to get more accurate results

Files Patch % Lines
rollup/core/classes/RollupLogger.cls 83.33% 2 Missing ⚠️
...llupForceRecalculation/rollupForceRecalculation.js 0.00% 1 Missing ⚠️
rollup/core/classes/RollupAsyncProcessor.cls 97.56% 1 Missing ⚠️
rollup/core/classes/RollupQueryBuilder.cls 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   96.53%   96.54%   +0.01%     
==========================================
  Files          32       32              
  Lines        6698     6693       -5     
  Branches       61       61              
==========================================
- Hits         6466     6462       -4     
+ Misses        227      226       -1     
  Partials        5        5              
Flag Coverage Δ
Apex 96.78% <94.73%> (+0.01%) ⬆️
LWC 92.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamessimone jamessimone merged commit 403fa58 into main Feb 23, 2024
@jamessimone jamessimone deleted the v1.6.15 branch February 23, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants