Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.6.29 - Grandparent rollup full recalc bugfixes #601

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

jamessimone
Copy link
Owner

  • Fixed an issue with grandparent rollups where all parents couldn't be retrieved in one go due to polymorphic fields being used
  • Fixes an issue reported by aesthetics where grandparent full recalc rollups with mutually exclusive where clauses could accidentally cache the previously filtered children from prior where clauses

…grandparent rollups when polymorphic fields are in play
…s, where recalcs started through the full recalc app would sometimes use only a cached subset of the children in each queueable/batch chunk
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.51%. Comparing base (a2770f3) to head (f8bd997).

Current head f8bd997 differs from pull request most recent head 4688bda

Please upload reports for the commit 4688bda to get more accurate results.

Files Patch % Lines
rollup/core/classes/RollupAsyncProcessor.cls 80.00% 2 Missing ⚠️
...lup/core/classes/RollupRelationshipFieldFinder.cls 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   96.56%   96.51%   -0.06%     
==========================================
  Files          33       33              
  Lines        6820     6832      +12     
  Branches       61       61              
==========================================
+ Hits         6586     6594       +8     
- Misses        229      233       +4     
  Partials        5        5              
Flag Coverage Δ
Apex 96.74% <91.66%> (-0.06%) ⬇️
LWC 92.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamessimone jamessimone merged commit 274d640 into main Jun 21, 2024
1 check passed
@jamessimone jamessimone deleted the v1.6.29 branch June 21, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants