Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint for _RequestHistoryTracker.reset method #259

Merged

Conversation

lhelwerd
Copy link
Contributor

This avoids mypy errors in typed code that follows the last example at https://requests-mock.readthedocs.io/en/latest/history.html#reset-history

@jamielennox jamielennox merged commit 9742d02 into jamielennox:master Apr 18, 2024
6 checks passed
@jamielennox
Copy link
Owner

thank you.

I keep having things like this, now that we don't support python2 any more i should merge the type hints because we keep missing little things like this.

@lhelwerd lhelwerd deleted the request-history-tracker-reset-typing branch April 19, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants