-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from Hosted Weblate #3284
Translations update from Hosted Weblate #3284
Conversation
bda6c1b
to
056f902
Compare
40b9c78
to
5683dd3
Compare
5683dd3
to
dbfb02d
Compare
Is this related to 3.11.0? We need to get it into the Tracking project with a milestone, if so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mansil I see there are several places where Diretório (meaning directory) has been replaced with Pasta (meaning folder). This may be fine when referring to a directory/folder in a file system, but doesn't make sense when referring to a Directory Server. For example line 3895. A Directory Server should use the same kind of word as for Telephone Directory.
ff741bd
to
080289e
Compare
080289e
to
c0eecdb
Compare
@softins probably it's worth reverting the directory thing? |
I guess this needs to be done via weblate? I can look up how to use that, but I'm a bit busy for a couple of days. |
No problem. Yes, it works over weblate. |
fbd0b21
to
6680010
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to do here. I believe we'd need to check with a pt_PT speaker.
@ignotus666 @softins how should we handle this? |
I can look later this week. The pt_PT PR has some translation errors in any case, conflating "directory" and "folder", which doesn't work for a directory server. I have signed up for weblate, but haven't yet had time to play with it. Also, it says the jamulus project is locked, so I don't know if I need to be given some permissions. |
Yes. I gave you permissions. |
I think the problem here was that I committed an The fact that the I'l wondering if it might be easiest to revert de60e5e temporarily, then get the pending updates validated and merged, and then redo the |
Currently translated at 100.0% (609 of 609 strings) Translation: Jamulus/Jamulus app Translate-URL: https://hosted.weblate.org/projects/jamulus/jamulus-app/pt_PT/
Currently translated at 100.0% (17 of 17 strings) Translation: Jamulus/Windows Installer Translate-URL: https://hosted.weblate.org/projects/jamulus/windows-installer/pt_PT/
Currently translated at 100.0% (609 of 609 strings) Translation: Jamulus/Jamulus app Translate-URL: https://hosted.weblate.org/projects/jamulus/jamulus-app/sv/
Currently translated at 100.0% (609 of 609 strings) Translation: Jamulus/Jamulus app Translate-URL: https://hosted.weblate.org/projects/jamulus/jamulus-app/pt_PT/
caca570
to
3d490a1
Compare
That's what I've done. The merge conflicts are no longer present, and weblate has unlocked the translation again automatically. I still have concerns about the ps_PT translation as mentioned above. I have asked @melcon via Discord if he would comment. |
Currently translated at 100.0% (609 of 609 strings) Translation: Jamulus/Jamulus app Translate-URL: https://hosted.weblate.org/projects/jamulus/jamulus-app/pt_PT/
The last commit 3d189f2 contains the reversions and a few other changes I did in weblate. I think this PR should be good enough to merge now. Any deficiencies discovered later could be dealt with separately. It would allow us to then get the I'm assuming the Swedish changes done by @genesisproject2020 will be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please approve and merge it then if you believe it's ok. I cannot comment.
Translations update from Hosted Weblate for Jamulus/Jamulus app.
It also includes following components:
Current translation status: