Display server versions in Connect dialog #3416
Conversation
|
Example screen shot:
|
|
If we add this, I think we should also consider again adding #1940 |
softins
force-pushed
the
display-server-versions
branch
2 times, most recently
from
faba634
to
0193705
Compare
|
I'd like it to be a bit more out of the way (last column) or entirely only showing up on hover (preferred as it's not essential) |
|
Well we could rearrange the columns (should probably create some defines or an enum for column numbers, so they can be changed only in one place in the code, matching the |
|
Personally, I prefer it where I showed above. |
|
It's not essential. Ping is more important for example. So it should not be second in my opinion |
|
Updated view. At least with an enum for column values it is easier to try different ways.
|
softins
force-pushed
the
display-server-versions
branch
from
d373be7
to
69dc4a3
Compare
Updated column indexes to match. Version column not yet populated.
softins
force-pushed
the
display-server-versions
branch
from
69dc4a3
to
24e9efc
Compare
This helps the first ping be a bit more accurate, as firewall/NAT sessions will already have been opened by the version request.
softins
force-pushed
the
display-server-versions
branch
from
24e9efc
to
e92696f
Compare
|
The linux standard window size seems to hide the version in the connect dialog. Not really a problem, but just so you know. |
| LVC_VERSION, // server version | ||
| LVC_PING_MIN_HIDDEN, // minimum ping time (invisible) | ||
| LVC_CLIENTS_MAX_HIDDEN, // maximum number of clients (invisible) | ||
| LVC_COLUMNS // total number of columns |
There was a problem hiding this comment.
Alternatively we could most likely also calculate this programmatically. It could go out of sync in future due to a mistake?
There was a problem hiding this comment.
I think a better approach would be to remove the headings from the widget in the .ui file and to set them in the code in the same section as we set the widths. I did consider this, but didn't get around to looking up the correct way to do so. Then the enum would be the one source of truth for column order.
That's interesting, I didn't notice that issue under Linux on my Pi; the connect window was wide enough to show the version column. Is the connect window size remembered in the |
|
Yes. The ini file has the correct size. I deleted the ini file to test the size and that's too small. |
I've updated the default width in |
Short description of changes
Adds a Version column to the server list in the Connect dialog, and populates this once for each server in the list.
CHANGELOG: Client: Display version for each server in the Connect dialog
Context: Fixes an issue?
This is a proof of concept in response to the discussion at https://github.com/orgs/jamulussoftware/discussions/3382#discussioncomment-10941423, although not itself related to access control.
Does this change need documentation? What needs to be documented and how?
On the website, any screenshots of the Connect dialog should be updated.
Status of this Pull Request
Ready for review. We can discuss whether to put it in 3.12.0 (if there is one) or 4.0.0
What is missing until this pull request can be merged?
Only a decision about when. We should also check the column width is ok on all platforms.
Checklist