blackbox-testing install and uninstall (#94)

bbtest/Dockerfile

@@ -26,6 +26,9 @@ RUN \
       exit 1 ; \
     fi
 
+RUN find . /etc/bbtest/packages -type f -name 'lake_*_amd64.deb' | \
+    xargs -I {} mv {} /etc/bbtest/packages/lake.deb
+
 RUN apt-get update && \
     apt-get install -y \
       init-system-helpers>=1.18~ \

bbtest/features/configuration.feature

@@ -1,18 +1,11 @@
 Feature: Service can be configured
 
-  Scenario: properly installed debian package
-    Given lake is running
-    Then systemctl contains following
-    """
-      lake.service
-    """
-
   Scenario: configure log level
     Given lake is reconfigured with
     """
       LOG_LEVEL=DEBUG
     """
-    Then journalctl of "lake.service" contains following
+    Then journalctl of "lake-relay.service" contains following
     """
       Log level set to DEBUG
     """
@@ -21,7 +14,7 @@ Feature: Service can be configured
     """
       LOG_LEVEL=ERROR
     """
-    Then journalctl of "lake.service" contains following
+    Then journalctl of "lake-relay.service" contains following
     """
       Log level set to ERROR
     """
@@ -30,7 +23,7 @@ Feature: Service can be configured
     """
       LOG_LEVEL=INFO
     """
-    Then journalctl of "lake.service" contains following
+    Then journalctl of "lake-relay.service" contains following
     """
       Log level set to INFO
     """

bbtest/features/install.feature

@@ -0,0 +1,11 @@
+@install
+Feature: Install package
+
+  Scenario: install
+    Given package "lake.deb" is installed
+    Then  systemctl contains following
+    """
+      lake-relay.service
+      lake.service
+      lake.path
+    """

bbtest/features/management.feature

@@ -4,16 +4,17 @@ Feature: Bootstrap shared
     Given lake is running
     And   systemctl contains following
     """
+      lake-relay.service
       lake.service
     """
 
-    When stop unit "lake.service"
-    Given unit "lake.service" is not running
+    When stop unit "lake-relay.service"
+    Given unit "lake-relay.service" is not running
 
-    When start unit "lake.service"
-    Given unit "lake.service" is running
+    When start unit "lake-relay.service"
+    Given unit "lake-relay.service" is running
 
-    When restart unit "lake.service"
-    Given unit "lake.service" is running
+    When restart unit "lake-relay.service"
+    Given unit "lake-relay.service" is running
 
     Then lake is running

bbtest/features/uninstall.feature

@@ -0,0 +1,11 @@
+@uninstall
+Feature: Unnstall package
+
+  Scenario: uninstall
+    Given package "lake" is uninstalled
+    Then  systemctl does not contains following
+    """
+      lake-relay.service
+      lake.service
+      lake.path
+    """

bbtest/spec.rb

@@ -7,11 +7,19 @@
 RSpec.configure do |config|
   config.raise_error_for_unimplemented_steps = true
   config.color = true
+  config.fail_fast = true
 
   Dir.glob("./helpers/*_helper.rb") { |f| load f }
   config.include EventuallyHelper, :type => :feature
   Dir.glob("./steps/*_steps.rb") { |f| load f, true }
 
+  config.register_ordering(:global) do |items|
+    (install, others) = items.partition { |spec| spec.metadata[:install] }
+    (uninstall, others) = others.partition { |spec| spec.metadata[:uninstall] }
+
+    install + others.shuffle + uninstall
+  end
+
   config.before(:suite) do |_|
     print "[ suite starting ]\n"
 
@@ -22,42 +30,20 @@
       %x(rm -rf #{folder}/*)
     }
 
-    print "[ installing package ]\n"
-
-    %x(find /etc/bbtest/packages -type f -name 'lake_*_amd64.deb')
-      .split("\n")
-      .map(&:strip)
-      .reject { |x| x.empty? }
-      .each { |package|
-        IO.popen("apt-get -y install -f #{package}") do |io|
-          while (line = io.gets) do
-            puts line
-          end
-        end
-      }
-
     print "[ suite started  ]\n"
   end
 
   config.after(:suite) do |_|
     print "\n[ suite ending   ]\n"
 
-    ids = %x(systemctl -a -t service --no-legend | awk '{ print $1 }')
-
-    if $?
-      ids = ids.split("\n").map(&:strip).reject { |x|
-        x.empty? || !x.start_with?("lake")
-      }.map { |x| x.chomp(".service") }
-    else
-      ids = []
-    end
-
-    ids.each { |e|
-      %x(journalctl -o short-precise -u #{e} --no-pager > /reports/#{e}.log 2>&1)
+    [
+      "lake",
+    ].each { |e|
+      %x(journalctl -o short-precise -u #{e}.service --no-pager > /reports/#{e}.log 2>&1)
       %x(systemctl stop #{e} 2>&1)
       %x(systemctl disable #{e} 2>&1)
-      %x(journalctl -o short-precise -u #{e} --no-pager > /reports/#{e}.log 2>&1)
-    } unless ids.empty?
+      %x(journalctl -o short-precise -u #{e}.service --no-pager > /reports/#{e}.log 2>&1)
+    }
 
     ZMQHelper.stop()
 

bbtest/steps/debian_steps.rb

@@ -1,10 +1,24 @@
 
+step "package :package is installed" do |package|
+  out = %x(apt-get -y install -f /etc/bbtest/packages/#{package})
+  expect($?).to be_success, out
+
+  expect(File.file?("/etc/init/lake.conf")).to be(true)
+end
+
+step "package :package is uninstalled" do |package|
+  out = %x(apt-get -y remove #{package})
+  expect($?).to be_success, out
+
+  expect(File.file?("/etc/init/lake.conf")).to be(false)
+end
+
 step "systemctl contains following" do |packages|
   items = packages.split("\n").map(&:strip).reject(&:empty?)
 
   eventually() {
     items.each { |item|
-      units = %x(systemctl -a -t service --no-legend | awk '{ print $1 }')
+      units = %x(systemctl list-units --no-legend | awk '{ print $1 }')
       units = units.split("\n").map(&:strip).reject(&:empty?)
       subset = units.reject { |x| !x.include?(item) }
       expect(subset).not_to be_empty, "\"#{item}\" was not found in #{units}"
@@ -16,10 +30,10 @@
   items = packages.split("\n").map(&:strip).reject(&:empty?)
 
   items.each { |item|
-    units = %x(systemctl -a -t service --no-legend | awk '{ print $1 }')
+    units = %x(systemctl list-units --no-legend | awk '{ print $1 }')
     units = units.split("\n").map(&:strip).reject(&:empty?)
     subset = units.reject { |x| !x.include?(item) }
-    expect(subset).to be_empty, "#{item} was found not found in #{units}"
+    expect(subset).to be_empty, "\"#{item}\" was found in #{units}"
   }
 end
 

bbtest/steps/orchestration_steps.rb

@@ -3,7 +3,7 @@
   expect($?).to be_success, ids
 
   ids = ids.split("\n").map(&:strip).reject { |x|
-    x.empty? || !x.start_with?("lake")
+    x.empty? || !x.start_with?("lake-")
   }.map { |x| x.chomp(".service") }
 
   expect(ids).not_to be_empty
@@ -22,7 +22,7 @@
 
 step "lake is running" do ||
   eventually() {
-    out = %x(systemctl show -p SubState lake 2>&1 | sed 's/SubState=//g')
+    out = %x(systemctl show -p SubState lake-relay 2>&1 | sed 's/SubState=//g')
     expect(out.strip).to eq("running")
   }
 
@@ -32,7 +32,7 @@
 end
 
 step "lake is reconfigured with" do |configuration|
-  params = Hash[configuration.split("\n").map(&:strip).reject(&:empty?).map {|el| el.split '='}]
+  params = Hash[configuration.split("\n").map(&:strip).reject(&:empty?).map { |el| el.split '=' }]
   defaults = {
     "LOG_LEVEL" => "DEBUG",
     "PORT_PULL" => "5562",
@@ -47,10 +47,10 @@
   %x(mkdir -p /etc/init)
   %x(echo '#{config}' > /etc/init/lake.conf)
 
-  %x(systemctl restart lake 2>&1)
+  %x(systemctl restart lake-relay 2>&1)
 
   eventually() {
-    out = %x(systemctl show -p SubState lake 2>&1 | sed 's/SubState=//g')
+    out = %x(systemctl show -p SubState lake-relay 2>&1 | sed 's/SubState=//g')
     expect(out.strip).to eq("running")
   }
 

packaging/debian_amd64/DEBIAN/control

@@ -1,5 +1,5 @@
 Package: lake
-Version: 1.1.4+lint-fixes
+Version: 1.1.4+test-install-uninstall
 Architecture: amd64
 Maintainer: Jan Cajthaml <jan.cajthaml@gmail.com>
 Depends: init-system-helpers (>= 1.18~), libzmq5 (>= 4.2.1~)

packaging/debian_amd64/DEBIAN/displace

@@ -1,2 +1 @@
 /etc/init/lake.conf
-/opt/lake/metrics/metrics.json

packaging/debian_amd64/DEBIAN/postinst

@@ -6,8 +6,18 @@ case "$1" in
 
   configure)
     if [ -f "/etc/init/lake.conf" ] ; then
-      systemctl unmask lake.service >/dev/null
-      systemctl enable lake.service >/dev/null
+      systemctl unmask \
+        lake.path \
+        lake.service \
+        lake-relay.service \
+      >/dev/null
+
+      systemctl enable \
+        lake.path \
+        lake.service \
+        lake-relay.service \
+      >/dev/null
+
       (systemctl start lake.service >/dev/null || :)
     else
       (>&2 echo "/etc/init/lake.conf file not found")

packaging/debian_amd64/DEBIAN/postrm

@@ -2,24 +2,50 @@
 
 set -e
 
+delete_service_files() {
+  if [ -f "/lib/systemd/system/lake-relay.service" ] ; then
+    rm /lib/systemd/system/lake-relay.service
+  fi
+
+  if [ -f "/lib/systemd/system/lake.service" ] ; then
+    rm /lib/systemd/system/lake.service
+  fi
+
+  if [ -f "/lib/systemd/system/lake.path" ] ; then
+    rm /lib/systemd/system/lake.path
+  fi
+}
+
+delete_displace_files() {
+  if [ -f "/etc/init/lake.conf" ] ; then
+    rm /etc/init/lake.conf
+  fi
+}
+
 case "$1" in
 
   purge)
-		systemctl stop lake.service
-		systemctl disable lake.service
-		(rm /lib/systemd/system/lake.service || :)
-		(rm /lib/systemd/system/lake.service || :)
-		(rm /etc/init/lake.conf || :)
-    (rm /opt/lake/metrics/metrics.json || :)
-		systemctl daemon-reload
-		systemctl reset-failed
-	;;
-
-	remove)
-		systemctl mask lake.service
-	;;
-
-  upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
+    # userdel openbank || :
+
+    delete_service_files
+    delete_displace_files
+
+    (systemctl daemon-reload || :)
+    (systemctl reset-failed || :)
+  ;;
+
+  remove)
+    (systemctl -a -t service --no-legend  | awk '$1 ~ /lake/ { print $1 }' | xargs -I {} systemctl stop {} 2> /dev/null || :)
+    (systemctl daemon-reload || :)
+
+    delete_displace_files
+  ;;
+
+  upgrade|deconfigure)
+    systemctl stop lake 2> /dev/null || :
+  ;;
+
+  remove|failed-upgrade|abort-install|abort-upgrade|disappear)
   ;;
 
   *)

packaging/debian_amd64/lib/systemd/system/lake-relay.service

@@ -0,0 +1,21 @@
+[Unit]
+Description=openbank lake message relay
+PartOf=lake.service
+After=lake.service
+
+[Service]
+Type=notify
+EnvironmentFile=/etc/init/lake.conf
+StartLimitBurst=0
+ExecStart=/openbank/services/lake/lake
+StandardInput=null
+LimitNOFILE=1048576
+LimitNPROC=infinity
+LimitCORE=infinity
+Restart=on-failure
+RestartSec=1
+TimeoutStartSec=0
+KillMode=process
+
+[Install]
+WantedBy=lake.service

packaging/debian_amd64/lib/systemd/system/lake.path

@@ -0,0 +1,9 @@
+[Unit]
+Description=openbank lake services namespace
+PartOf=lake.service
+
+[Path]
+PathChanged=/etc/init/lake.conf
+
+[Install]
+WantedBy=lake.service

packaging/debian_amd64/lib/systemd/system/lake.service

@@ -3,18 +3,9 @@ Description=openbank lake message relay
 After=inetd.service
 
 [Service]
-Type=notify
-EnvironmentFile=/etc/init/lake.conf
-StartLimitBurst=0
-ExecStart=/openbank/services/lake/lake
-StandardInput=null
-LimitNOFILE=1048576
-LimitNPROC=infinity
-LimitCORE=infinity
-Restart=on-failure
-RestartSec=1
-TimeoutStartSec=0
-KillMode=process
+Type=oneshot
+ExecStart=/bin/true
+RemainAfterExit=yes
 
 [Install]
 WantedBy=multi-user.target

packaging/debian_armhf/DEBIAN/displace

@@ -1,2 +1 @@
 /etc/init/lake.conf
-/opt/lake/metrics/metrics.json