nitpicking (#141)

services/vault-unit/actor/common.go

@@ -25,8 +25,6 @@ import (
 	money "gopkg.in/inf.v0"
 )
 
-var nilCoordinates = system.Coordinates{}
-
 // ProcessLocalMessage processing of local message to this vault
 func ProcessLocalMessage(s *ActorSystem) system.ProcessLocalMessage {
 	return func(message interface{}, to system.Coordinates, from system.Coordinates) {
@@ -52,7 +50,7 @@ func asEnvelopes(s *ActorSystem, msg string) (system.Coordinates, system.Coordin
 	parts := strings.Split(msg, " ")
 
 	if len(parts) < 5 {
-		return nilCoordinates, nilCoordinates, nil, fmt.Errorf("invalid message received %+v", parts)
+		return system.Coordinates{}, system.Coordinates{}, nil, fmt.Errorf("invalid message received %+v", parts)
 	}
 
 	recieverRegion, senderRegion, receiverName, senderName := parts[0], parts[1], parts[2], parts[3]

services/vault-unit/boot/init.go

@@ -27,8 +27,8 @@ import (
 	"github.com/jancajthaml-openbank/vault-unit/utils"
 )
 
-// Application encapsulate initialized application
-type Application struct {
+// Program encapsulate initialized application
+type Program struct {
 	cfg             config.Configuration
 	interrupt       chan os.Signal
 	metrics         metrics.Metrics
@@ -38,7 +38,7 @@ type Application struct {
 }
 
 // Initialize application
-func Initialize() Application {
+func Initialize() Program {
 	ctx, cancel := context.WithCancel(context.Background())
 
 	cfg := config.GetConfig()
@@ -51,7 +51,7 @@ func Initialize() Application {
 	actorSystemDaemon := actor.NewActorSystem(ctx, cfg.Tenant, cfg.LakeHostname, &metricsDaemon, &storage)
 	snapshotUpdaterDaemon := persistence.NewSnapshotUpdater(ctx, cfg.JournalSaturation, cfg.SnapshotScanInterval, &metricsDaemon, &storage, actor.ProcessLocalMessage(&actorSystemDaemon))
 
-	return Application{
+	return Program{
 		cfg:             cfg,
 		interrupt:       make(chan os.Signal, 1),
 		metrics:         metricsDaemon,

services/vault-unit/boot/run.go

@@ -27,12 +27,12 @@ import (
 )
 
 // Stop stops the application
-func (app Application) Stop() {
+func (app Program) Stop() {
 	close(app.interrupt)
 }
 
 // WaitReady wait for daemons to be ready
-func (app Application) WaitReady(deadline time.Duration) error {
+func (app Program) WaitReady(deadline time.Duration) error {
 	errors := make([]error, 0)
 	mux := new(sync.Mutex)
 
@@ -63,19 +63,19 @@ func (app Application) WaitReady(deadline time.Duration) error {
 }
 
 // GreenLight daemons
-func (app Application) GreenLight() {
+func (app Program) GreenLight() {
 	app.metrics.GreenLight()
 	app.actorSystem.GreenLight()
 	app.snapshotUpdater.GreenLight()
 }
 
 // WaitInterrupt wait for signal
-func (app Application) WaitInterrupt() {
+func (app Program) WaitInterrupt() {
 	<-app.interrupt
 }
 
 // Run runs the application
-func (app Application) Run() {
+func (app Program) Run() {
 	log.Info(">>> Start <<<")
 
 	go app.metrics.Start()

services/vault-unit/main.go

@@ -19,7 +19,7 @@ import (
 )
 
 func main() {
-	application := boot.Initialize()
-	defer application.Stop()
-	application.Run()
+	program := boot.Initialize()
+	defer program.Stop()
+	program.Run()
 }