Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove docstring #317

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

remove docstring #317

wants to merge 4 commits into from

Conversation

mzouink
Copy link
Member

@mzouink mzouink commented Nov 3, 2024

This PR is just en case you want to remove the LLM generated docstrings - no merge now

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 49.98%. Comparing base (926bb2d) to head (ee9c1b9).
Report is 128 commits behind head on main.

Files with missing lines Patch % Lines
dacapo/cli.py 0.00% 65 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   55.83%   49.98%   -5.85%     
==========================================
  Files         197      199       +2     
  Lines        7150     7424     +274     
==========================================
- Hits         3992     3711     -281     
- Misses       3158     3713     +555     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There appear to be some python formatting errors in
0e236a9. This pull request
uses the [psf/black](https://github.com/psf/black) formatter to fix
these issues.
@pattonw
Copy link
Contributor

pattonw commented Nov 7, 2024

Removing the LLM doc strings seems like a good idea to me. I have read some that seem to take up a lot of space and not provide much benefit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants