Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ocaml-base-compiler version. #168

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

folone
Copy link

@folone folone commented Jun 28, 2024

Problem

ocaml-base-compiler version was updated in 21579b5. Since then, it looks like the github builds have been failing with

  [ERROR] No solution for base:   * No agreement on the version of ocaml-base-compiler:
              - (invariant) → ocaml-base-compiler = 4.14.0
              - base → ocaml >= 5.1.0 → ocaml-base-compiler >= 5.1.0~
              You can temporarily relax the switch invariant with `--update-invariant'
            * Missing dependency:
              - base → ocaml >= 5.1.0 → ocaml-variants >= 5.1.0~ → system-msvc
              unmet availability conditions: 'os = "win32"'

Solution

Update the ocaml version to 5.
As a drive-by, updating the setup-ocaml gh action version to v3, since v2 did not support windows os for ocaml 5.
Another drive-by is updating the checkout action version, to keep this workflow up-to-date.

@folone folone force-pushed the gl/fix-build branch 2 times, most recently from 7a74e61 to 9b7f3ab Compare June 28, 2024 14:10
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Jul 3, 2024
@folone folone force-pushed the gl/fix-build branch 5 times, most recently from 8792361 to f74e2f4 Compare December 29, 2024 16:52
Signed-off-by: George Leontiev <george.leontiev@reddit.com>
Signed-off-by: George Leontiev <george.leontiev@reddit.com>
@folone folone force-pushed the gl/fix-build branch 2 times, most recently from 5937bee to 3b7c82e Compare December 29, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants