Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled shortcut create new thread on starter screen #4074

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Nov 21, 2024

Describe Your Changes

The Git diff shows that there have been some modifications made to the KeyListener.tsx file located in the web/containers/Providers directory. Here's a detailed description of the changes:

  1. Import Statement:

    • A new import statement for useStarterScreen has been added from '@/hooks/useStarterScreen'.
  2. Variable Declaration:

    • A new variable isShowStarterScreen is declared by destructuring from the useStarterScreen hook.
  3. UseEffect Dependency Update:

    • The dependency array of the useEffect hook has been updated to include the newly added isShowStarterScreen.
  4. Conditional Check in useEffect:

    • Inside the onKeyDown event handler, there is a conditional check to ensure that the isShowStarterScreen is false before proceeding with certain actions.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Nov 21, 2024
@urmauur urmauur added this to the v0.5.10 milestone Nov 21, 2024
@urmauur urmauur self-assigned this Nov 21, 2024
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.26%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@urmauur urmauur merged commit 8b485ba into dev Nov 22, 2024
11 checks passed
@urmauur urmauur deleted the fix/disabled-shortcut-create-new-thread branch November 22, 2024 05:53
@github-actions github-actions bot modified the milestones: v0.5.10, v0.5.9 Nov 22, 2024
@urmauur urmauur modified the milestones: v0.5.9, v0.5.10 Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants