Add review comments for parser

jantimon · Jul 19, 2024 · e344732 · e344732
1 parent 06916ee
commit e344732
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/yak-swc/css_in_js_parser/src/parse_css.rs b/packages/yak-swc/css_in_js_parser/src/parse_css.rs
@@ -4,7 +4,7 @@ use serde_repr::*;
 
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct ParserState {
-  pub is_inside_string: Option<char>,
+  pub is_inside_string: Option<char>, // TODO: enum
   pub current_comment_state: CommentStateType,
   pub is_inside_property_value: bool,
   pub is_inside_at_rule: bool,
@@ -123,6 +123,7 @@ pub fn parse_css(
       back_slashes = 0;
     }
 
+    // TODO: Consider resetting backslashes
     match state.current_comment_state {
       // Parse until the end of the current multi line comment is reached
       CommentStateType::MultiLine => {

diff --git a/packages/yak-swc/css_in_js_parser/src/to_css.rs b/packages/yak-swc/css_in_js_parser/src/to_css.rs
@@ -46,6 +46,7 @@ pub fn to_css(declarations: &[Declaration]) -> String {
   css
 }
 
+// TODO: remove
 pub fn to_css_with_state(
   declarations: &[Declaration],
   parser_state: Option<ParserState>,