Skip to content

Commit

Permalink
chore(deps): change deps to peer deps in common packages (#2404)
Browse files Browse the repository at this point in the history
* chore(deps): change deps to peer deps in common packages

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix dep

Signed-off-by: Paul Schultz <pschultz@pobox.com>

---------

Signed-off-by: Paul Schultz <pschultz@pobox.com>
  • Loading branch information
schultzp2020 authored Oct 18, 2024
1 parent 59374c5 commit 2bebc8c
Show file tree
Hide file tree
Showing 11 changed files with 30 additions and 19 deletions.
12 changes: 12 additions & 0 deletions .changeset/perfect-ways-marry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"@janus-idp/backstage-plugin-orchestrator-common": patch
"@janus-idp/backstage-plugin-bulk-import-common": patch
"@janus-idp/backstage-plugin-topology-common": patch
"@janus-idp/backstage-plugin-tekton-common": patch
"@janus-idp/backstage-plugin-ocm-backend": patch
"@janus-idp/backstage-plugin-quay-common": patch
"@janus-idp/backstage-plugin-rbac-common": patch
"@janus-idp/backstage-plugin-ocm-common": patch
---

change deps to peer deps in common packages
2 changes: 1 addition & 1 deletion plugins/bulk-import-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"prettier": "3.3.3",
"@backstage/cli": "0.27.1"
},
"dependencies": {
"peerDependencies": {
"@backstage/plugin-permission-common": "^0.8.1"
},
"files": [
Expand Down
4 changes: 2 additions & 2 deletions plugins/ocm-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
"scripts": {
"build": "backstage-cli package build",
"clean": "backstage-cli package clean",
"export-dynamic": "janus-cli package export-dynamic-plugin --embed-package --embed-package @backstage/plugin-kubernetes-common",
"export-dynamic:clean": "janus-cli package export-dynamic-plugin --embed-package --embed-package @backstage/plugin-kubernetes-common --clean",
"export-dynamic": "janus-cli package export-dynamic-plugin --embed-package @backstage/plugin-kubernetes-common",
"export-dynamic:clean": "janus-cli package export-dynamic-plugin --embed-package @backstage/plugin-kubernetes-common --clean",
"lint:check": "backstage-cli package lint",
"lint:fix": "backstage-cli package lint --fix",
"postpack": "backstage-cli package postpack",
Expand Down
2 changes: 1 addition & 1 deletion plugins/ocm-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
],
"homepage": "https://red.ht/rhdh",
"bugs": "https://github.com/janus-idp/backstage-plugins/issues",
"dependencies": {
"peerDependencies": {
"@backstage/plugin-permission-common": "^0.8.1"
},
"maintainers": [
Expand Down
9 changes: 5 additions & 4 deletions plugins/orchestrator-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,20 @@
"openapi:check": "./scripts/openapi.sh check",
"openapi:prettier:fix": "prettier --ignore-unknown --write ./src/generated/api"
},
"dependencies": {
"@backstage/types": "^1.1.1",
"peerDependencies": {
"@backstage/plugin-permission-common": "^0.8.1",
"@severlessworkflow/sdk-typescript": "^3.0.3",
"js-yaml": "^4.1.0",
"json-schema": "^0.4.0",
"axios": "^1.7.4"
},
"devDependencies": {
"prettier": "3.3.3",
"@backstage/cli": "0.27.1",
"@backstage/types": "1.1.1",
"json-schema": "0.4.0",
"@openapitools/openapi-generator-cli": "2.13.4",
"js-yaml-cli": "0.6.0"
"js-yaml-cli": "0.6.0",
"@severlessworkflow/sdk-typescript": "3.0.3"
},
"maintainers": [
"@janus-idp/maintainers-plugins",
Expand Down
8 changes: 4 additions & 4 deletions plugins/orchestrator-common/src/types.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { JsonObject } from '@backstage/types';
import type { JsonObject } from '@backstage/types';

import { Specification } from '@severlessworkflow/sdk-typescript';
import { JSONSchema7, JSONSchema7Definition } from 'json-schema';
import type { Specification } from '@severlessworkflow/sdk-typescript';
import type { JSONSchema7, JSONSchema7Definition } from 'json-schema';

import { ProcessInstance, ProcessInstanceStateValues } from './models';
import type { ProcessInstance, ProcessInstanceStateValues } from './models';

type Id<T> = { [P in keyof T]: T[P] };

Expand Down
4 changes: 1 addition & 3 deletions plugins/quay-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,8 @@
"files": [
"dist"
],
"dependencies": {
"@backstage/plugin-permission-common": "^0.8.1"
},
"peerDependencies": {
"@backstage/plugin-permission-common": "^0.8.1",
"react": "16.13.1 || ^17.0.0 || ^18.0.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion plugins/rbac-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"prepack": "backstage-cli package prepack",
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"peerDependencies": {
"@backstage/plugin-permission-common": "^0.8.1",
"@backstage/errors": "^1.2.4"
},
Expand Down
2 changes: 1 addition & 1 deletion plugins/tekton-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"prettier:check": "prettier --ignore-unknown --check .",
"prettier:fix": "prettier --ignore-unknown --write ."
},
"dependencies": {
"peerDependencies": {
"@backstage/plugin-permission-common": "^0.8.1"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion plugins/topology-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
],
"homepage": "https://red.ht/rhdh",
"bugs": "https://github.com/janus-idp/backstage-plugins/issues",
"dependencies": {
"peerDependencies": {
"@backstage/plugin-permission-common": "^0.8.1"
},
"maintainers": [
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2bebc8c

Please sign in to comment.