Skip to content

Commit

Permalink
fix(orchestrator): remove docs feature (#2341)
Browse files Browse the repository at this point in the history
* Revert "fix(orchestrator): fix dynamic plugin build (#2326)"

This reverts commit 7a3b155.

* fix(orchestrator): remove docs feature that breaks multi-release-version
  • Loading branch information
batzionb authored Oct 10, 2024
1 parent c7f0231 commit e71f083
Show file tree
Hide file tree
Showing 5 changed files with 49 additions and 85 deletions.
12 changes: 6 additions & 6 deletions plugins/orchestrator-backend/dist-dynamic/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "2.2.0",
"license": "Apache-2.0",
"main": "./dist/index.cjs.js",
"types": "./dist/index.d.ts",
"types": "src/index.ts",
"publishConfig": {
"access": "public"
},
Expand All @@ -20,7 +20,6 @@
"exports": {
".": {
"require": "./dist/index.cjs.js",
"types": "./dist/index.d.ts",
"default": "./dist/index.cjs.js"
},
"./package.json": "./package.json"
Expand All @@ -47,7 +46,6 @@
],
"scripts": {},
"dependencies": {
"@janus-idp/backstage-plugin-orchestrator-common": "*",
"@urql/core": "^4.1.4",
"ajv-formats": "^2.1.1",
"cloudevents": "^8.0.0",
Expand All @@ -58,7 +56,10 @@
"json-schema": "^0.4.0",
"moment": "^2.29.4",
"openapi-backend": "^5.10.5",
"yn": "^5.0.0"
"yn": "^5.0.0",
"@severlessworkflow/sdk-typescript": "^3.0.3",
"js-yaml": "^4.1.0",
"axios": "^1.7.4"
},
"devDependencies": {},
"peerDependencies": {
Expand Down Expand Up @@ -90,7 +91,6 @@
}
},
"resolutions": {
"@aws-sdk/util-utf8-browser": "npm:@smithy/util-utf8@~2",
"@janus-idp/backstage-plugin-orchestrator-common": "file:./embedded/janus-idp-backstage-plugin-orchestrator-common"
"@aws-sdk/util-utf8-browser": "npm:@smithy/util-utf8@~2"
}
}
106 changes: 42 additions & 64 deletions plugins/orchestrator-backend/dist-dynamic/yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion plugins/orchestrator-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"prepack": "backstage-cli package prepack",
"postpack": "backstage-cli package postpack",
"postversion": "yarn run export-dynamic",
"export-dynamic": "janus-cli package export-dynamic-plugin"
"export-dynamic": "janus-cli package export-dynamic-plugin --no-embed-as-dependencies"
},
"dependencies": {
"@backstage/backend-common": "^0.23.3",
Expand Down
4 changes: 0 additions & 4 deletions plugins/orchestrator-backend/src/OrchestratorPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ export const orchestratorPlugin = createBackendPlugin({
path: '/health',
allow: 'unauthenticated',
});
httpRouter.addAuthPolicy({
path: '/docs',
allow: 'unauthenticated',
});
},
});
},
Expand Down
10 changes: 0 additions & 10 deletions plugins/orchestrator-backend/src/service/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,6 @@ export async function createBackendRouter(
router.use(permissionsIntegrationRouter);
router.use('/workflows', express.text());
router.use('/static', express.static(resolvePackagePath(pkg.name, 'static')));
router.use(
'/docs',
express.static(
resolvePackagePath(
'@janus-idp/backstage-plugin-orchestrator-common',
'src/generated/docs/html',
),
),
);

router.get('/health', (_, response) => {
logger.info('PONG!');
response.json({ status: 'ok' });
Expand Down

0 comments on commit e71f083

Please sign in to comment.