fix(bulk-import): updated bulk import ui to show the correct import jobs count #2315

debsmita1 · 2024-10-07T19:29:53Z

Resolves:

Note: Used @tanstack/react-query for querying the import jobs

Screenshots:

When the number of rows listed is less than the number of rows selected
(https://issues.redhat.com/browse/RHIDP-3868)

rm3l

@debsmita1 I just tested this PR, and can confirm both https://issues.redhat.com/browse/RHIDP-4067 and https://issues.redhat.com/browse/RHIDP-3868 are fixed.

However, I noticed what I think could be a regression: when trying to import new repos, the "Create pull request" button remains disabled regardless of the repos selected. See the screencast attached:

review-pr-2315-2024-10-09_11.07.04.mp4

Do you confirm this behavior on your end?

rm3l · 2024-10-09T11:51:20Z

@debsmita1 I just tested this PR, and can confirm both issues.redhat.com/browse/RHIDP-4067 and issues.redhat.com/browse/RHIDP-3868 are fixed.

However, I noticed what I think could be a regression: when trying to import new repos, the "Create pull request" button remains disabled regardless of the repos selected. See the screencast attached:

review-pr-2315-2024-10-09_11.07.04.mp4
Do you confirm this behavior on your end?

I can also confirm this issue does not occur on the main branch.

debsmita1 · 2024-10-10T07:07:42Z

@debsmita1 I just tested this PR, and can confirm both https://issues.redhat.com/browse/RHIDP-4067 and https://issues.redhat.com/browse/RHIDP-3868 are fixed.

However, I noticed what I think could be a regression: when trying to import new repos, the "Create pull request" button remains disabled regardless of the repos selected. See the screencast attached:

review-pr-2315-2024-10-09_11.07.04.mp4
Do you confirm this behavior on your end?

Fixed it. PTAL

rm3l

@debsmita1 I just tested this PR, and can confirm both issues.redhat.com/browse/RHIDP-4067 and issues.redhat.com/browse/RHIDP-3868 are fixed.
However, I noticed what I think could be a regression: when trying to import new repos, the "Create pull request" button remains disabled regardless of the repos selected. See the screencast attached:
review-pr-2315-2024-10-09_11.07.04.mp4
Do you confirm this behavior on your end?

Fixed it. PTAL

It works better now - thanks. LGTM, but I'll let frontend experts take a look as well.

christoph-jerolimov

Some small comments and questions:

plugins/bulk-import/package.json

plugins/bulk-import/src/api/BulkImportBackendClient.test.ts

plugins/bulk-import/src/components/AddRepositories/OrganizationTableRow.tsx

plugins/bulk-import/src/components/AddRepositories/RepositoryTableRow.tsx

plugins/bulk-import/src/components/Repositories/DeleteRepositoryDialog.tsx

plugins/bulk-import/src/components/Repositories/RepositoriesList.tsx

changeset-bot · 2024-10-16T11:16:36Z

🦋 Changeset detected

Latest commit: 5fd57b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@janus-idp/backstage-plugin-bulk-import	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sonarcloud · 2024-10-16T11:53:45Z

Quality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

christoph-jerolimov · 2024-10-18T10:23:28Z

plugins/bulk-import/src/components/BulkImportPage.tsx

-            <RepositoriesList />
-          </FormControl>
-        </Formik>
+        <QueryClientProvider client={queryClientRef.current as QueryClient}>


as always trigger me ;)

Suggested change

<QueryClientProvider client={queryClientRef.current as QueryClient}>

<QueryClientProvider client={queryClientRef.current!}>

christoph-jerolimov · 2024-10-18T10:30:12Z

plugins/bulk-import/src/components/Repositories/CatalogInfoAction.tsx

+              values?.repositories?.[data.id]?.catalogInfoYaml?.prTemplate
                ?.pullRequestUrl ||
-              values?.repositories[data.id]?.repoUrl ||
+              values?.repositories?.[data.id]?.repoUrl ||


Anyway, the code generates a link that isn't clickable in some cases.

With the recommended check we can ensure that we don't create a button that doesn't open a valid link.

christoph-jerolimov

Tiny nits

christoph-jerolimov · 2024-10-18T10:45:13Z

plugins/bulk-import/src/components/Repositories/AddedRepositoryTableRow.tsx

+  const classes = useStyles();
+
+  return (
+    <TableRow hover key={data.id}>


nit, but I guess the key here isn't needed.

christoph-jerolimov · 2024-10-18T10:51:42Z

plugins/bulk-import/src/components/Repositories/AddedRepositoryTableRow.tsx

+        <Link to={data?.repoUrl || ''}>
+          {urlHelper(data?.repoUrl || '')}
+          <OpenInNewIcon style={{ verticalAlign: 'sub', paddingTop: '7px' }} />
+        </Link>


As mentioned in other places. We should avoid rendering broken links.

christoph-jerolimov · 2024-10-18T10:51:48Z

plugins/bulk-import/src/components/Repositories/AddedRepositoryTableRow.tsx

+        <Link to={data?.organizationUrl || ''}>
+          {urlHelper(data?.organizationUrl || '')}
+          <OpenInNewIcon style={{ verticalAlign: 'sub', paddingTop: '7px' }} />
+        </Link>


As mentioned in other places. We should avoid rendering broken links.

christoph-jerolimov

Thanks for the update. Please take care of the left overs as part of your other bulk import PR.

/lgtm

christoph-jerolimov · 2024-10-20T21:30:57Z

/override SonarCloud Code Analysis

openshift-ci · 2024-10-20T21:31:02Z

@jerolimov: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

Analysis
Code
SonarCloud

Only the following failed contexts/checkruns were expected:

Build with Node.js 20
Conventional Commits
SonarCloud Code Analysis
Test with Node.js 20
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override SonarCloud Code Analysis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

christoph-jerolimov · 2024-10-20T21:31:19Z

/override "SonarCloud Code Analysis"

openshift-ci · 2024-10-20T21:31:23Z

@jerolimov: Overrode contexts on behalf of jerolimov: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…obs count (janus-idp#2315) [Bulk import]: fix added repositories count

debsmita1 requested a review from a team as a code owner October 7, 2024 19:29

openshift-ci bot requested review from dzemanov and Fortune-Ndlovu October 7, 2024 19:29

debsmita1 requested review from christoph-jerolimov, invincibleJai and ciiay October 7, 2024 19:30

debsmita1 changed the title ~~fix(bulk-import): Updated bulk import ui to show the correct import jobs count~~ fix(bulk-import): updated bulk import ui to show the correct import jobs count Oct 7, 2024

debsmita1 force-pushed the update-bi-imports branch from d396e2d to 6fbb740 Compare October 8, 2024 07:23

debsmita1 changed the title ~~fix(bulk-import): updated bulk import ui to show the correct import jobs count~~ [WIP] fix(bulk-import): updated bulk import ui to show the correct import jobs count Oct 8, 2024

openshift-ci bot added the do-not-merge/work-in-progress label Oct 8, 2024

debsmita1 force-pushed the update-bi-imports branch from 6fbb740 to 3d4bd53 Compare October 8, 2024 12:53

debsmita1 changed the title ~~[WIP] fix(bulk-import): updated bulk import ui to show the correct import jobs count~~ fix(bulk-import): updated bulk import ui to show the correct import jobs count Oct 8, 2024

openshift-ci bot removed the do-not-merge/work-in-progress label Oct 8, 2024

debsmita1 force-pushed the update-bi-imports branch from 3d4bd53 to 41107eb Compare October 8, 2024 13:19

debsmita1 requested a review from rm3l October 8, 2024 13:21

debsmita1 force-pushed the update-bi-imports branch from 41107eb to 4857098 Compare October 8, 2024 13:56

rm3l reviewed Oct 9, 2024

View reviewed changes

debsmita1 force-pushed the update-bi-imports branch 2 times, most recently from 354ca95 to c73b5d9 Compare October 9, 2024 19:20

debsmita1 requested a review from rm3l October 10, 2024 07:05

rm3l reviewed Oct 10, 2024

View reviewed changes

christoph-jerolimov requested changes Oct 15, 2024

View reviewed changes

openshift-ci bot assigned christoph-jerolimov Oct 15, 2024

debsmita1 force-pushed the update-bi-imports branch 2 times, most recently from facd635 to b92f16c Compare October 16, 2024 11:16

debsmita1 force-pushed the update-bi-imports branch from b92f16c to aa42ed2 Compare October 16, 2024 11:31

debsmita1 requested a review from a team as a code owner October 16, 2024 11:31

debsmita1 requested a review from christoph-jerolimov October 16, 2024 11:31

[Bulk import]: fix added repositories count

5fd57b8

debsmita1 force-pushed the update-bi-imports branch from aa42ed2 to 5fd57b8 Compare October 16, 2024 11:52

christoph-jerolimov reviewed Oct 18, 2024

View reviewed changes

christoph-jerolimov requested changes Oct 18, 2024

View reviewed changes

christoph-jerolimov approved these changes Oct 20, 2024

View reviewed changes

openshift-ci bot added the lgtm label Oct 20, 2024

openshift-merge-bot bot merged commit 7a28963 into janus-idp:main Oct 20, 2024
9 of 10 checks passed

04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Oct 23, 2024

fix(bulk-import): updated bulk import ui to show the correct import j…

ab0a0a0

…obs count (janus-idp#2315) [Bulk import]: fix added repositories count

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(bulk-import): updated bulk import ui to show the correct import jobs count #2315

fix(bulk-import): updated bulk import ui to show the correct import jobs count #2315

debsmita1 commented Oct 7, 2024 •

edited

Loading

rm3l left a comment

rm3l commented Oct 9, 2024

debsmita1 commented Oct 10, 2024

rm3l left a comment

christoph-jerolimov left a comment

changeset-bot bot commented Oct 16, 2024 •

edited

Loading

sonarcloud bot commented Oct 16, 2024

christoph-jerolimov Oct 18, 2024

christoph-jerolimov Oct 18, 2024

christoph-jerolimov left a comment

christoph-jerolimov Oct 18, 2024

christoph-jerolimov Oct 18, 2024

christoph-jerolimov Oct 18, 2024

christoph-jerolimov left a comment •

edited

Loading

christoph-jerolimov commented Oct 20, 2024

openshift-ci bot commented Oct 20, 2024

christoph-jerolimov commented Oct 20, 2024

openshift-ci bot commented Oct 20, 2024

	<QueryClientProvider client={queryClientRef.current as QueryClient}>
	<QueryClientProvider client={queryClientRef.current!}>

fix(bulk-import): updated bulk import ui to show the correct import jobs count #2315

fix(bulk-import): updated bulk import ui to show the correct import jobs count #2315

Conversation

debsmita1 commented Oct 7, 2024 • edited Loading

rm3l left a comment

Choose a reason for hiding this comment

rm3l commented Oct 9, 2024

debsmita1 commented Oct 10, 2024

rm3l left a comment

Choose a reason for hiding this comment

christoph-jerolimov left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Oct 16, 2024 • edited Loading

🦋 Changeset detected

sonarcloud bot commented Oct 16, 2024

Quality Gate failed

christoph-jerolimov Oct 18, 2024

Choose a reason for hiding this comment

christoph-jerolimov Oct 18, 2024

Choose a reason for hiding this comment

christoph-jerolimov left a comment

Choose a reason for hiding this comment

christoph-jerolimov Oct 18, 2024

Choose a reason for hiding this comment

christoph-jerolimov Oct 18, 2024

Choose a reason for hiding this comment

christoph-jerolimov Oct 18, 2024

Choose a reason for hiding this comment

christoph-jerolimov left a comment • edited Loading

Choose a reason for hiding this comment

christoph-jerolimov commented Oct 20, 2024

openshift-ci bot commented Oct 20, 2024

christoph-jerolimov commented Oct 20, 2024

openshift-ci bot commented Oct 20, 2024

debsmita1 commented Oct 7, 2024 •

edited

Loading

changeset-bot bot commented Oct 16, 2024 •

edited

Loading

christoph-jerolimov left a comment •

edited

Loading