-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rbac): move admin creation to its own file #2349
fix(rbac): move admin creation to its own file #2349
Conversation
The sonarcloud analysis is failing because of the amount of duplication that is in this PR. My plan is to clean this up in a separate PR. |
a19643e
to
848c45e
Compare
🦋 Changeset detectedLatest commit: dcb9437 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this pull request and would like to merge it as soon as possible. However, I wonder if the admin-creation.ts file might be better placed in a separate package, perhaps something like 'admin-role' or similar, as it doesn’t seem directly related to file permissions. What are your thoughts on this?
@AndrienkoAleksandr I am fine with that. I only picked the |
ee0fd27
to
dcb9437
Compare
Quality Gate failedFailed conditions |
/override sonarcloud |
@AndrienkoAleksandr: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "SonarCloud Code Analysis" |
@AndrienkoAleksandr: Overrode contexts on behalf of AndrienkoAleksandr: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
a5abb98
into
janus-idp:main
* fix(rbac): move admin creation to its own file * fix(rbac): move test fixtures directory up a level * fix(rbac): add mock utils fixture * fix(rbac): rename mock services to be in line with fixtures mock * fix(rbac): update import path * fix(rbac): rename test file * fix(rbac): add admin creation tests * fix(rbac): add missing changeset * fix(rbac): move admin creation to the admin-permissions directory
Description
Moves the admin creation to its own file to simplify the code base a little bit. This will also help in the future if we ever decide to allow for the reloading of admins from within the app-config.
Also included is a number of other updates.
The future refactor should help with some of the duplication issues that we are seeing within SonarCloud