fix(janus-idp/cli): fixes issue with missing configSchema.json #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5a1e2f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kadel
force-pushed
the
fix-configSchema
branch
2 times, most recently
from
83f3e5b to
4fb58c9
Compare
This was affecting packages in @backstage-community
kadel
force-pushed
the
fix-configSchema
branch
from
4fb58c9 to
086eb40
Compare
nickboldt
approved these changes
Oct 16, 2024
|
gashcrumb
approved these changes
Oct 17, 2024
|
/cherrypick release-1.3 |
|
@kadel: new pull request created: #2411 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
04kash
pushed a commit
to 04kash/backstage-plugins
that referenced
this pull request
Oct 23, 2024
…-idp#2368) This was affecting packages in @backstage-community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that plugins in
@backstage-communitywere accidentally ignored when searching for config schemas becausestartsWith('@backstage')was used as a main filtering rule.So, when the @backstage-community namespace was introduced and plugins were migrated to it, it started to ignore them.
This simple fix ensures that only packages in the core
@backstagecan be filtered out.Fixes: https://issues.redhat.com/browse/RHIDP-3574