Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430) #2370

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

nickboldt
Copy link
Member

@nickboldt nickboldt commented Oct 16, 2024

What does this PR do?

chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430)

Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@nickboldt nickboldt requested a review from a team as a code owner October 16, 2024 13:50
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 84a3ae7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nickboldt nickboldt changed the title chore(release) only the release action... chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430) Oct 16, 2024
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430)". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - chore
 - docs
 - style
 - refactor
 - perf
 - test
 - revert

…me; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430)

Signed-off-by: Nick Boldt <nboldt@redhat.com>
…PR, actions in progress will be cancelled to start a fresh one

Signed-off-by: Nick Boldt <nboldt@redhat.com>
Copy link

sonarcloud bot commented Oct 16, 2024

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2024
@nickboldt nickboldt changed the title chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430) chore(release): only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430) Oct 16, 2024
@nickboldt nickboldt merged commit 5cf60df into main Oct 16, 2024
5 of 9 checks passed
@nickboldt nickboldt deleted the 4430 branch October 16, 2024 14:02
@nickboldt
Copy link
Member Author

/cherry-pick release-1.3

@openshift-cherrypick-robot

@nickboldt: new pull request created: #2372

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@schultzp2020
Copy link
Member

/cherry-pick 1.2.x

@openshift-cherrypick-robot

@schultzp2020: #2370 failed to apply on top of branch "1.2.x":

Applying: chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430)
Using index info to reconstruct a base tree...
A	.github/workflows/pr-build.yaml
A	.github/workflows/pr-test.yaml
A	.github/workflows/release.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): .github/workflows/release.yaml deleted in HEAD and modified in chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430). Version chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430) of .github/workflows/release.yaml left in tree.
CONFLICT (modify/delete): .github/workflows/pr-test.yaml deleted in HEAD and modified in chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430). Version chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430) of .github/workflows/pr-test.yaml left in tree.
CONFLICT (modify/delete): .github/workflows/pr-build.yaml deleted in HEAD and modified in chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430). Version chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430) of .github/workflows/pr-build.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 chore(release) only the release action should be gated to one at a time; PR build and test should be able to run in parallel across multiple PRs (RHIDP-4430)

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants