Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): include embedded folder for keycloak-backend #2406

Conversation

AndrienkoAleksandr
Copy link
Collaborator

Include embedded folder for keycloak-backend. Previous attempt was in the wrong place: #2353

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr requested a review from a team as a code owner October 21, 2024 10:38
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: e295a23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@janus-idp/backstage-plugin-keycloak-backend Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr requested a review from a team as a code owner October 21, 2024 11:15
Copy link

@dzemanov
Copy link
Member

Looks good to me. Not sure if this should be major change.

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4e93fe0 into janus-idp:main Oct 21, 2024
9 checks passed
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Oct 23, 2024
…dp#2406)

* chore(release): include embedded folder for keycloak-backend

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

* chore(release): add changeset

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

---------

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants