fix(rbac): prevent policy creation when rbac plugin is disabled #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatAKnight
requested review from
AndrienkoAleksandr and
a team
as code owners
🦋 Changeset detectedLatest commit: 4881150 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PatAKnight
force-pushed
the
prevent-policy-creation
branch
from
25b0bdf to
ea6730e
Compare
PatAKnight
force-pushed
the
prevent-policy-creation
branch
from
ea6730e to
4881150
Compare
|
AndrienkoAleksandr
approved these changes
Oct 28, 2024
|
/override "SonarCloud Code Analysis" |
|
@PatAKnight: Overrode contexts on behalf of PatAKnight: SonarCloud Code Analysis In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new allow all permission policy that can be used to whenever the permission framework is disabled. This allows us to skip the creation of a number of resources because we load in this allow all permission policy instead of the RBAC one.
Also included is a number of other updates.
policiesand moves theallow-all-policy.tsandpermission-policy.tsto this directoryPoliciesServeras there was some duplicates