Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gh): update/remove gh actions #2416

Merged
merged 3 commits into from
Oct 22, 2024
Merged

chore(gh): update/remove gh actions #2416

merged 3 commits into from
Oct 22, 2024

Conversation

schultzp2020
Copy link
Member

@schultzp2020 schultzp2020 commented Oct 22, 2024

Changes:

  • Removed the dirty yarn.lock check since Yarn v3 now uses the --immutable flag during yarn install in CI environments.
  • Deleted yarn-lock.yaml as it's no longer necessary (same reason as above).
  • Renamed pr-playwright to pr-ui-test and updated the action to use Turbo instead.
  • Deleted publish-backend-plugin-manager.yaml as it is no longer required.
  • Merge PR tests into a single file.

Signed-off-by: Paul Schultz <pschultz@pobox.com>
@schultzp2020 schultzp2020 requested review from a team as code owners October 22, 2024 17:44
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 44cb624

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Signed-off-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: Paul Schultz <pschultz@pobox.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
20.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@schultzp2020
Copy link
Member Author

/override "Build with Node.js 20"

Merged into a single file.

Copy link

openshift-ci bot commented Oct 22, 2024

@schultzp2020: Overrode contexts on behalf of schultzp2020: Build with Node.js 20

In response to this:

/override "Build with Node.js 20"

Merged into a single file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@schultzp2020
Copy link
Member Author

/override "Test with Node.js 20"

Merged into a single file.

Copy link

openshift-ci bot commented Oct 22, 2024

@schultzp2020: Overrode contexts on behalf of schultzp2020: Test with Node.js 20

In response to this:

/override "Test with Node.js 20"

Merged into a single file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@schultzp2020
Copy link
Member Author

/override "SonarCloud Code Analysis"

Code analysis should not be looking at this PR.

Copy link

openshift-ci bot commented Oct 22, 2024

@schultzp2020: Overrode contexts on behalf of schultzp2020: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Code analysis should not be looking at this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kim-tsao
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 22, 2024
@schultzp2020 schultzp2020 merged commit cf7c430 into main Oct 22, 2024
7 of 9 checks passed
@schultzp2020 schultzp2020 deleted the maintain-actions branch October 22, 2024 18:15
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Oct 23, 2024
* chore(gh): update/remove gh actions

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* fix script typo

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* merge pr tests into one file

Signed-off-by: Paul Schultz <pschultz@pobox.com>

---------

Signed-off-by: Paul Schultz <pschultz@pobox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants