Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix the issue where an argument for concurrency is supplied twice #2430

Merged

Conversation

PatAKnight
Copy link
Member

Description

The tests are failing being an argument for concurrency is being supplied twice. This PR aims to fix it by removing the argument in the package.json so that it mirrors the main branch

PRs with the failing tests

@PatAKnight PatAKnight requested a review from a team as a code owner October 23, 2024 12:21
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 6581dd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schultzp2020
Copy link
Member

/lgtm
/approve

@schultzp2020
Copy link
Member

@PatAKnight can you backport this to 1.2 as well?

@PatAKnight
Copy link
Member Author

@schultzp2020 It just seems to be this branch that had the concurrency argument. 1.2.x is fine

@PatAKnight PatAKnight requested a review from a team as a code owner October 23, 2024 12:44
@openshift-ci openshift-ci bot removed the lgtm label Oct 23, 2024
Copy link

sonarcloud bot commented Oct 23, 2024

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3bc6cc8 into janus-idp:release-1.3 Oct 23, 2024
12 checks passed
@schultzp2020 schultzp2020 mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants