Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orchestrator): execute should allow no inputs #2550

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

batzionb
Copy link
Contributor

The bug is that execute fails also if field inputData is passed but is empty.
This causes workflows without required inputs to fail.

Resolves FLPATH-1880

@batzionb batzionb requested review from a team as code owners November 21, 2024 12:59
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 6d2d638

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@batzionb
Copy link
Contributor Author

@gciavarrini
Please review
I didn't create a PR on main branch because of migration to rhdh-plugins
I'll create a PR there once it's in

@batzionb batzionb requested a review from a team as a code owner November 21, 2024 13:25
Copy link

sonarcloud bot commented Nov 21, 2024

@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 65b8b23 into janus-idp:release-1.3 Nov 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants