chore(cli): update error message #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gashcrumb
requested review from
davidfestal,
jesuino and
kadel
as code owners
🦋 Changeset detectedLatest commit: 8cbc31c The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gashcrumb
force-pushed
the
update-error-msg
branch
from
3bad992 to
22485aa
Compare
schultzp2020
requested changes
Nov 27, 2024
packages/cli/src/commands/export-dynamic-plugin/backend-embed-as-dependencies.ts
Outdated
Show resolved
Hide resolved
gashcrumb
force-pushed
the
update-error-msg
branch
from
22485aa to
0ef44e5
Compare
This change updates the error message produced by the native replacement package to make it clear that native modules are not currently supported. This change also includes two small fixes suggested by sonarqube. Signed-off-by: Stan Lewis <gashcrumb@gmail.com>
gashcrumb
force-pushed
the
update-error-msg
branch
from
0ef44e5 to
8cbc31c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the error message produced by the native replacement package to make it clear that native modules are not currently supported. This change also includes two small fixes suggested by sonarqube.